Repository: zeppelin
Updated Branches:
  refs/heads/branch-0.7 75cf72e9b -> 000900faf


[ZEPPELIN-2113] Paragraph border is not highlighted when focused

### What is this PR for?
https://github.com/apache/zeppelin/pull/2054 [removes `paragraph-col` css 
class](https://github.com/apache/zeppelin/pull/2054/files#diff-fe483b8eb5467153a772f202838dfb18L115).
 As a result paragraph is not highlighted when focused.

This PR apply `paragraph-col` css class when it is not iframe mode.

### What type of PR is it?
Bug Fix

### Todos
* [x] - apply `paragraph-col` css class

### What is the Jira issue?
http://issues.apache.org/jira/browse/ZEPPELIN-2113

### How should this be tested?
Click any paragraph and see if paragraph border is highlighted

### Screenshots (if appropriate)

before
![zeppelin_focus_no](https://cloud.githubusercontent.com/assets/1540981/23927184/78061500-08d5-11e7-8136-aaa53d8a4f35.gif)

after
![zeppelin_focus_on](https://cloud.githubusercontent.com/assets/1540981/23927192/804d93a0-08d5-11e7-9136-35dc17aca902.gif)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: Lee moon soo <m...@apache.org>

Closes #2136 from Leemoonsoo/ZEPPELIN-2113-followup and squashes the following 
commits:

45c1717 [Lee moon soo] apply paragraph-col class

(cherry picked from commit a47ff95ed97cfdc52baeb22aa923d784e82afbe4)
Signed-off-by: Lee moon soo <m...@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/000900fa
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/000900fa
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/000900fa

Branch: refs/heads/branch-0.7
Commit: 000900faf1064cbfce9009cc8dcf8b1717b119ee
Parents: 75cf72e
Author: Lee moon soo <m...@apache.org>
Authored: Tue Mar 14 16:36:02 2017 -0700
Committer: Lee moon soo <m...@apache.org>
Committed: Thu Mar 16 08:49:10 2017 -0700

----------------------------------------------------------------------
 zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zeppelin/blob/000900fa/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js 
b/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
index 937f89b..222ab12 100644
--- a/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
+++ b/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
@@ -417,7 +417,7 @@ function ParagraphCtrl($scope, $rootScope, $route, $window, 
$routeParams, $locat
     if ($scope.asIframe) {
       return 'col-md-12';
     } else {
-      return 'col-md-' + n;
+      return 'paragraph-col col-md-' + n;
     }
   };
 

Reply via email to