Repository: zeppelin
Updated Branches:
refs/heads/master 9eb580cd3 -> 7984ada24
[MINOR] Add trivial cosmetic changes on STYLE.md
### What is this PR for?
This PR proposes a little bit of cosmetic changes on `STYLE.md`.
**Before**
```
"src-noconflict/mode-sql.js",
"src-noconflict/mode-markdown.js",
"src-noconflict/keybinding-emacs.js",
"src-noconflict/ext-language_tools.js",
+ "src-noconflict/theme-github.js"],
"version": "1.1.8",
"name": "ace-builds"
},
"highlightjs": {
"main": ["highlight.pack.js",
+ "styles/github.css"],
"version": "8.4.0",
"name": "highlightjs"
}
```
```
- $scope.editor.setTheme('ace/theme/github');
+ $scope.editor.setTheme('ace/theme/monokai');
```
```
- "src-noconflict/theme-github.js"],
+ "src-noconflict/theme-monokai.js"],
```
**After**
```diff
"src-noconflict/mode-sql.js",
"src-noconflict/mode-markdown.js",
"src-noconflict/keybinding-emacs.js",
"src-noconflict/ext-language_tools.js",
+ "src-noconflict/theme-github.js"],
"version": "1.1.8",
"name": "ace-builds"
},
"highlightjs": {
"main": ["highlight.pack.js",
+ "styles/github.css"],
"version": "8.4.0",
"name": "highlightjs"
}
```
```diff
- $scope.editor.setTheme('ace/theme/github');
+ $scope.editor.setTheme('ace/theme/monokai');
```
```diff
- "src-noconflict/theme-github.js"],
+ "src-noconflict/theme-monokai.js"],
```
### What type of PR is it?
[Documentation]
### What is the Jira issue?
MINOR
### How should this be tested?
Manually checked the rendering
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? N/A
Author: hyukjinkwon <gurwls...@gmail.com>
Closes #1763 from HyukjinKwon/minor-fix and squashes the following commits:
a6fcbd3 [hyukjinkwon] Add trivial cosmetic changes on STYLE.md
Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/7984ada2
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/7984ada2
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/7984ada2
Branch: refs/heads/master
Commit: 7984ada24ae11b66d9db7ed641e927320b842c1f
Parents: 9eb580c
Author: hyukjinkwon <gurwls...@gmail.com>
Authored: Thu Dec 15 11:44:24 2016 +0900
Committer: Felix Cheung <felixche...@apache.org>
Committed: Sun Dec 18 12:13:34 2016 -0800
----------------------------------------------------------------------
STYLE.md | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/7984ada2/STYLE.md
----------------------------------------------------------------------
diff --git a/STYLE.md b/STYLE.md
index db6a40c..8182301 100644
--- a/STYLE.md
+++ b/STYLE.md
@@ -25,11 +25,11 @@ bower.json
In the override section at the bottom, include the Highlightjs stylesheet (eg.
styles/github.css)
For the selected Ace Editor theme script, include it in the override section.
(eg. src-noconflict/theme-github.js)
(bower will automatically add the appropriate .js and .css in app/index.html)
-```
+```diff
"src-noconflict/mode-sql.js",
"src-noconflict/mode-markdown.js",
"src-noconflict/keybinding-emacs.js",
- "src-noconflict/ext-language_tools.js",
+ "src-noconflict/ext-language_tools.js",
+ "src-noconflict/theme-github.js"],
"version": "1.1.8",
"name": "ace-builds"
@@ -48,13 +48,13 @@ Highlight.js style - depends on the style, a few themes
have jpg - if so, one mu
### Example - change Ace Editor theme to monokai
app/scripts/controllers/paragraph.js
-```
+```diff
- $scope.editor.setTheme('ace/theme/github');
+ $scope.editor.setTheme('ace/theme/monokai');
```
bower.json
-```
+```diff
- "src-noconflict/theme-github.js"],
+ "src-noconflict/theme-monokai.js"],
```
