Repository: zeppelin Updated Branches: refs/heads/master 9694a1a5b -> 823e2e024
[ZEPPELIN-1705] Exclude unnecessary source file when check style on scio ### What is this PR for? When building Zeppelin with `mvn clean package install -DskipTests -DskipRat`, it fails on `scio` with an error log below: ```sh [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:2.13:check (checkstyle-fail-build) on project zeppelin-scio_2.10: You have 51 Checkstyle violations. -> [Help 1] ``` This is because of **style check on a generated source**, which is exactly `$ZEPPELIN_HOME/scio/target/generated-sources/avro/org/apache/zeppelin/scio/avro/Account.java` This PR will make style check excludes the generated source. ### What type of PR is it? Bug Fix ### What is the Jira issue? [ZEPPELIN-1705](https://issues.apache.org/jira/browse/ZEPPELIN-1705) ### How should this be tested? Run `mvn clean package install -DskipTests -DskipRat`. It should print `BUILD SUCCESS` ### Questions: * Does the licenses files need update? NO * Is there breaking changes for older versions? NO * Does this needs documentation? NO Author: Jun <i2r....@gmail.com> Closes #1676 from tae-jun/ZEPPELIN-1705 and squashes the following commits: 2c1c56b [Jun] Exclude unnecessary source file when check style on scio Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/823e2e02 Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/823e2e02 Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/823e2e02 Branch: refs/heads/master Commit: 823e2e02488dd1a4788eabaa37c531e6a3f4583c Parents: 9694a1a Author: Jun <i2r....@gmail.com> Authored: Thu Nov 24 20:37:19 2016 +0900 Committer: ahyoungryu <ahyoung...@apache.org> Committed: Sat Nov 26 20:33:50 2016 +0900 ---------------------------------------------------------------------- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/zeppelin/blob/823e2e02/pom.xml ---------------------------------------------------------------------- diff --git a/pom.xml b/pom.xml index ea5adf1..cfe9e90 100644 --- a/pom.xml +++ b/pom.xml @@ -261,7 +261,7 @@ </goals> <configuration> <failOnViolation>true</failOnViolation> - <excludes>org/apache/zeppelin/interpreter/thrift/*</excludes> + <excludes>org/apache/zeppelin/interpreter/thrift/*,org/apache/zeppelin/scio/avro/*,org/apache/zeppelin/scio/avro/*</excludes> </configuration> </execution> <execution> @@ -271,7 +271,7 @@ <goal>checkstyle-aggregate</goal> </goals> <configuration> - <excludes>org/apache/zeppelin/interpreter/thrift/*</excludes> + <excludes>org/apache/zeppelin/interpreter/thrift/*,org/apache/zeppelin/scio/avro/*,org/apache/zeppelin/scio/avro/*</excludes> </configuration> </execution> </executions>
