(ws-wss4j) branch master updated: Cleaning up some codeql findings in the dom tests

[coheigea]

This is an automated email from the ASF dual-hosted git repository.

coheigea pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ws-wss4j.git


The following commit(s) were added to refs/heads/master by this push:
     new b1ab30eb3 Cleaning up some codeql findings in the dom tests
b1ab30eb3 is described below

commit b1ab30eb3b03632c22db5d43258286cb5aa70f5d
Author: Colm O hEigeartaigh <cohei...@apache.org>
AuthorDate: Thu Jan 8 11:53:48 2026 +0000

    Cleaning up some codeql findings in the dom tests
---
 .../src/test/java/org/apache/wss4j/dom/handler/CallbackRefTest.java | 4 ----
 .../test/java/org/apache/wss4j/dom/handler/UseReqSigCertTest.java   | 2 --
 .../java/org/apache/wss4j/dom/handler/WSHandlerGetPasswordTest.java | 4 ----
 .../src/test/java/org/apache/wss4j/dom/message/EncryptionTest.java  | 6 ++----
 4 files changed, 2 insertions(+), 14 deletions(-)

diff --git 
a/ws-security-dom/src/test/java/org/apache/wss4j/dom/handler/CallbackRefTest.java
 
b/ws-security-dom/src/test/java/org/apache/wss4j/dom/handler/CallbackRefTest.java
index 5b3b9f094..0bf6348ca 100644
--- 
a/ws-security-dom/src/test/java/org/apache/wss4j/dom/handler/CallbackRefTest.java
+++ 
b/ws-security-dom/src/test/java/org/apache/wss4j/dom/handler/CallbackRefTest.java
@@ -66,8 +66,6 @@ public class CallbackRefTest {
         );
         reqData.setMsgContext(messageContext);
 
-        final java.util.List<Integer> actions = new java.util.ArrayList<>();
-        actions.add(WSConstants.UT);
         Document doc = SOAPUtil.toSOAPPart(SOAPUtil.SAMPLE_SOAP_MSG);
         CustomHandler handler = new CustomHandler();
         HandlerAction action = new HandlerAction(WSConstants.UT);
@@ -102,8 +100,6 @@ public class CallbackRefTest {
         reqData.setPwType(WSConstants.PASSWORD_TEXT);
         reqData.setMsgContext(new java.util.TreeMap<String, String>());
 
-        final java.util.List<Integer> actions = new java.util.ArrayList<>();
-        actions.add(WSConstants.UT);
         Document doc = SOAPUtil.toSOAPPart(SOAPUtil.SAMPLE_SOAP_MSG);
         CustomHandler handler = new CustomHandler();
         handler.setOption(WSHandlerConstants.PW_CALLBACK_REF, callbackHandler);
diff --git 
a/ws-security-dom/src/test/java/org/apache/wss4j/dom/handler/UseReqSigCertTest.java
 
b/ws-security-dom/src/test/java/org/apache/wss4j/dom/handler/UseReqSigCertTest.java
index e0e9a1824..50dd14002 100644
--- 
a/ws-security-dom/src/test/java/org/apache/wss4j/dom/handler/UseReqSigCertTest.java
+++ 
b/ws-security-dom/src/test/java/org/apache/wss4j/dom/handler/UseReqSigCertTest.java
@@ -211,8 +211,6 @@ public class UseReqSigCertTest {
         config.put(WSHandlerConstants.RECV_RESULTS, handlerResults);
         reqData.setMsgContext(config);
 
-        final List<Integer> actions = new ArrayList<>();
-        actions.add(WSConstants.ENCR);
         final Document doc = SOAPUtil.toSOAPPart(SOAPUtil.SAMPLE_SOAP_MSG);
 
         // Send message
diff --git 
a/ws-security-dom/src/test/java/org/apache/wss4j/dom/handler/WSHandlerGetPasswordTest.java
 
b/ws-security-dom/src/test/java/org/apache/wss4j/dom/handler/WSHandlerGetPasswordTest.java
index e4009b432..aeda26f84 100644
--- 
a/ws-security-dom/src/test/java/org/apache/wss4j/dom/handler/WSHandlerGetPasswordTest.java
+++ 
b/ws-security-dom/src/test/java/org/apache/wss4j/dom/handler/WSHandlerGetPasswordTest.java
@@ -88,8 +88,6 @@ public class WSHandlerGetPasswordTest {
         messageContext.put("password", "securityPassword");
         reqData.setMsgContext(messageContext);
 
-        final java.util.List<Integer> actions = new java.util.ArrayList<>();
-        actions.add(WSConstants.UT);
         Document doc = SOAPUtil.toSOAPPart(SOAPUtil.SAMPLE_SOAP_MSG);
         CustomHandler handler = new CustomHandler();
         HandlerAction action = new HandlerAction(WSConstants.UT);
@@ -129,8 +127,6 @@ public class WSHandlerGetPasswordTest {
         );
         reqData.setMsgContext(messageContext);
 
-        final java.util.List<Integer> actions = new java.util.ArrayList<>();
-        actions.add(WSConstants.UT);
         Document doc = SOAPUtil.toSOAPPart(SOAPUtil.SAMPLE_SOAP_MSG);
         CustomHandler handler = new CustomHandler();
         HandlerAction action = new HandlerAction(WSConstants.UT);
diff --git 
a/ws-security-dom/src/test/java/org/apache/wss4j/dom/message/EncryptionTest.java
 
b/ws-security-dom/src/test/java/org/apache/wss4j/dom/message/EncryptionTest.java
index 6e44a441b..3d51055bf 100644
--- 
a/ws-security-dom/src/test/java/org/apache/wss4j/dom/message/EncryptionTest.java
+++ 
b/ws-security-dom/src/test/java/org/apache/wss4j/dom/message/EncryptionTest.java
@@ -801,11 +801,10 @@ public class EncryptionTest {
          */
         SOAPConstants soapConstants = WSSecurityUtil.getSOAPConstants(doc
                 .getDocumentElement());
-        java.util.List<WSEncryptionPart> parts = new ArrayList<>();
         WSEncryptionPart encP = new WSEncryptionPart(soapConstants
                 .getBodyQName().getLocalPart(), soapConstants.getEnvelopeURI(),
                 "Content");
-        parts.add(encP);
+        builder.getParts().add(encP);
 
         /*
          * Encrypt the parts (Body), create EncryptedData elements that 
reference
@@ -871,11 +870,10 @@ public class EncryptionTest {
 
         SOAPConstants soapConstants = WSSecurityUtil.getSOAPConstants(doc
                 .getDocumentElement());
-        java.util.List<WSEncryptionPart> parts = new ArrayList<>();
         WSEncryptionPart encP = new WSEncryptionPart(soapConstants
                 .getBodyQName().getLocalPart(), soapConstants.getEnvelopeURI(),
                 "Content");
-        parts.add(encP);
+        builder.getParts().add(encP);
 
         builder.encrypt(symmetricKey);