This is an automated email from the ASF dual-hosted git repository. coheigea pushed a commit to branch coheigea/saml-refactor-new in repository https://gitbox.apache.org/repos/asf/ws-wss4j.git
commit 18b0bae38d2e3e8451e34752d368a1467b324517 Author: Colm O hEigeartaigh <cohei...@apache.org> AuthorDate: Tue Jun 17 09:48:46 2025 +0100 Moving WSDocInfo to ws-security-common --- .../main/java/org/apache/wss4j/common}/dom/WSDocInfo.java | 13 +++++++------ .../java/org/apache/wss4j/dom/engine/WSSecurityEngine.java | 2 +- .../main/java/org/apache/wss4j/dom/handler/RequestData.java | 2 +- .../main/java/org/apache/wss4j/dom/handler/WSHandler.java | 2 +- .../main/java/org/apache/wss4j/dom/message/Encryptor.java | 2 +- .../main/java/org/apache/wss4j/dom/message/WSSecBase.java | 2 +- .../main/java/org/apache/wss4j/dom/message/WSSecDKSign.java | 2 +- .../java/org/apache/wss4j/dom/message/WSSecSignature.java | 2 +- .../org/apache/wss4j/dom/message/WSSecSignatureBase.java | 2 +- .../apache/wss4j/dom/processor/EncryptedKeyProcessor.java | 2 +- .../org/apache/wss4j/dom/processor/SignatureProcessor.java | 2 +- .../java/org/apache/wss4j/dom/saml/WSSecSignatureSAML.java | 2 +- .../org/apache/wss4j/dom/str/EncryptedKeySTRParser.java | 2 +- .../main/java/org/apache/wss4j/dom/str/STRParserUtil.java | 2 +- .../org/apache/wss4j/dom/str/SecurityTokenRefSTRParser.java | 2 +- .../java/org/apache/wss4j/dom/str/SignatureSTRParser.java | 2 +- .../java/org/apache/wss4j/dom/transform/STRTransform.java | 2 +- .../org/apache/wss4j/dom/transform/STRTransformUtil.java | 2 +- .../java/org/apache/wss4j/dom/util/EncryptionUtils.java | 2 +- .../main/java/org/apache/wss4j/dom/util/SignatureUtils.java | 2 +- 20 files changed, 26 insertions(+), 25 deletions(-) diff --git a/ws-security-dom/src/main/java/org/apache/wss4j/dom/WSDocInfo.java b/ws-security-common/src/main/java/org/apache/wss4j/common/dom/WSDocInfo.java similarity index 96% rename from ws-security-dom/src/main/java/org/apache/wss4j/dom/WSDocInfo.java rename to ws-security-common/src/main/java/org/apache/wss4j/common/dom/WSDocInfo.java index 25143486e..033545dfa 100644 --- a/ws-security-dom/src/main/java/org/apache/wss4j/dom/WSDocInfo.java +++ b/ws-security-common/src/main/java/org/apache/wss4j/common/dom/WSDocInfo.java @@ -17,7 +17,7 @@ * under the License. */ -package org.apache.wss4j.dom; +package org.apache.wss4j.common.dom; /** * WSDocInfo holds information about the document to process. It provides a @@ -39,6 +39,7 @@ import java.util.Map; import javax.xml.crypto.dom.DOMCryptoContext; +import org.apache.wss4j.common.WSS4JConstants; import org.apache.wss4j.common.crypto.Crypto; import org.apache.wss4j.common.dom.callback.CallbackLookup; import org.apache.wss4j.common.dom.engine.WSSecurityEngineResult; @@ -108,9 +109,9 @@ public class WSDocInfo { return; } - if (element.hasAttributeNS(WSConstants.WSU_NS, "Id")) { - String id = element.getAttributeNS(WSConstants.WSU_NS, "Id"); - TokenValue tokenValue = new TokenValue("Id", WSConstants.WSU_NS, element); + if (element.hasAttributeNS(WSS4JConstants.WSU_NS, "Id")) { + String id = element.getAttributeNS(WSS4JConstants.WSU_NS, "Id"); + TokenValue tokenValue = new TokenValue("Id", WSS4JConstants.WSU_NS, element); TokenValue previousValue = tokens.put(id, tokenValue); if (checkMultipleElements && previousValue != null) { throw new WSSecurityException( @@ -132,7 +133,7 @@ public class WSDocInfo { // SAML Assertions if ("Assertion".equals(element.getLocalName())) { - if (WSConstants.SAML_NS.equals(element.getNamespaceURI()) + if (WSS4JConstants.SAML_NS.equals(element.getNamespaceURI()) && element.hasAttributeNS(null, "AssertionID")) { String id = element.getAttributeNS(null, "AssertionID"); TokenValue tokenValue = new TokenValue("AssertionID", null, element); @@ -142,7 +143,7 @@ public class WSDocInfo { WSSecurityException.ErrorCode.INVALID_SECURITY_TOKEN, "duplicateError" ); } - } else if (WSConstants.SAML2_NS.equals(element.getNamespaceURI()) + } else if (WSS4JConstants.SAML2_NS.equals(element.getNamespaceURI()) && element.hasAttributeNS(null, "ID")) { String id = element.getAttributeNS(null, "ID"); TokenValue tokenValue = new TokenValue("ID", null, element); diff --git a/ws-security-dom/src/main/java/org/apache/wss4j/dom/engine/WSSecurityEngine.java b/ws-security-dom/src/main/java/org/apache/wss4j/dom/engine/WSSecurityEngine.java index f5dad8716..18acda868 100644 --- a/ws-security-dom/src/main/java/org/apache/wss4j/dom/engine/WSSecurityEngine.java +++ b/ws-security-dom/src/main/java/org/apache/wss4j/dom/engine/WSSecurityEngine.java @@ -34,7 +34,7 @@ import org.apache.wss4j.common.dom.callback.CallbackLookup; import org.apache.wss4j.common.dom.callback.DOMCallbackLookup; import org.apache.wss4j.common.ext.WSSecurityException; import org.apache.wss4j.dom.WSConstants; -import org.apache.wss4j.dom.WSDocInfo; +import org.apache.wss4j.common.dom.WSDocInfo; import org.apache.wss4j.dom.handler.RequestData; import org.apache.wss4j.dom.handler.WSHandlerResult; import org.apache.wss4j.dom.processor.Processor; diff --git a/ws-security-dom/src/main/java/org/apache/wss4j/dom/handler/RequestData.java b/ws-security-dom/src/main/java/org/apache/wss4j/dom/handler/RequestData.java index 6339ae10c..8115d540d 100644 --- a/ws-security-dom/src/main/java/org/apache/wss4j/dom/handler/RequestData.java +++ b/ws-security-dom/src/main/java/org/apache/wss4j/dom/handler/RequestData.java @@ -43,7 +43,7 @@ import org.apache.wss4j.common.crypto.AlgorithmSuite; import org.apache.wss4j.common.crypto.Crypto; import org.apache.wss4j.common.crypto.PasswordEncryptor; import org.apache.wss4j.common.ext.WSSecurityException; -import org.apache.wss4j.dom.WSDocInfo; +import org.apache.wss4j.common.dom.WSDocInfo; import org.apache.wss4j.dom.engine.WSSConfig; import org.apache.wss4j.dom.message.WSSecHeader; import org.apache.wss4j.dom.validate.Validator; diff --git a/ws-security-dom/src/main/java/org/apache/wss4j/dom/handler/WSHandler.java b/ws-security-dom/src/main/java/org/apache/wss4j/dom/handler/WSHandler.java index e5c0a3830..fd907c86b 100644 --- a/ws-security-dom/src/main/java/org/apache/wss4j/dom/handler/WSHandler.java +++ b/ws-security-dom/src/main/java/org/apache/wss4j/dom/handler/WSHandler.java @@ -29,7 +29,7 @@ import javax.security.auth.callback.Callback; import javax.security.auth.callback.CallbackHandler; import org.apache.wss4j.dom.WSConstants; -import org.apache.wss4j.dom.WSDocInfo; +import org.apache.wss4j.common.dom.WSDocInfo; import org.apache.wss4j.dom.engine.WSSConfig; import org.apache.wss4j.common.dom.engine.WSSecurityEngineResult; import org.apache.wss4j.common.EncryptionActionToken; diff --git a/ws-security-dom/src/main/java/org/apache/wss4j/dom/message/Encryptor.java b/ws-security-dom/src/main/java/org/apache/wss4j/dom/message/Encryptor.java index 26300f7a7..07974eaca 100644 --- a/ws-security-dom/src/main/java/org/apache/wss4j/dom/message/Encryptor.java +++ b/ws-security-dom/src/main/java/org/apache/wss4j/dom/message/Encryptor.java @@ -44,7 +44,7 @@ import org.apache.wss4j.common.ext.WSSecurityException; import org.apache.wss4j.common.util.AttachmentUtils; import org.apache.wss4j.common.util.XMLUtils; import org.apache.wss4j.dom.WSConstants; -import org.apache.wss4j.dom.WSDocInfo; +import org.apache.wss4j.common.dom.WSDocInfo; import org.apache.wss4j.dom.WsuIdAllocator; import org.apache.wss4j.dom.util.WSSecurityUtil; import org.apache.xml.security.algorithms.JCEMapper; diff --git a/ws-security-dom/src/main/java/org/apache/wss4j/dom/message/WSSecBase.java b/ws-security-dom/src/main/java/org/apache/wss4j/dom/message/WSSecBase.java index aa2020bd4..77b163faf 100644 --- a/ws-security-dom/src/main/java/org/apache/wss4j/dom/message/WSSecBase.java +++ b/ws-security-dom/src/main/java/org/apache/wss4j/dom/message/WSSecBase.java @@ -24,7 +24,7 @@ import org.apache.wss4j.common.dom.callback.CallbackLookup; import org.apache.wss4j.common.dom.callback.DOMCallbackLookup; import org.apache.wss4j.common.util.XMLUtils; import org.apache.wss4j.dom.WSConstants; -import org.apache.wss4j.dom.WSDocInfo; +import org.apache.wss4j.common.dom.WSDocInfo; import org.apache.wss4j.dom.WsuIdAllocator; import org.apache.wss4j.dom.engine.WSSConfig; import org.w3c.dom.Document; diff --git a/ws-security-dom/src/main/java/org/apache/wss4j/dom/message/WSSecDKSign.java b/ws-security-dom/src/main/java/org/apache/wss4j/dom/message/WSSecDKSign.java index ff6ccef0e..2ae87bc4d 100644 --- a/ws-security-dom/src/main/java/org/apache/wss4j/dom/message/WSSecDKSign.java +++ b/ws-security-dom/src/main/java/org/apache/wss4j/dom/message/WSSecDKSign.java @@ -48,7 +48,7 @@ import org.apache.wss4j.common.token.SecurityTokenReference; import org.apache.wss4j.common.util.KeyUtils; import org.apache.wss4j.common.util.XMLUtils; import org.apache.wss4j.dom.WSConstants; -import org.apache.wss4j.dom.WSDocInfo; +import org.apache.wss4j.common.dom.WSDocInfo; import org.apache.wss4j.dom.transform.STRTransform; import org.apache.wss4j.dom.util.WSSecurityUtil; diff --git a/ws-security-dom/src/main/java/org/apache/wss4j/dom/message/WSSecSignature.java b/ws-security-dom/src/main/java/org/apache/wss4j/dom/message/WSSecSignature.java index 3024b0aa4..1f87cd6e0 100644 --- a/ws-security-dom/src/main/java/org/apache/wss4j/dom/message/WSSecSignature.java +++ b/ws-security-dom/src/main/java/org/apache/wss4j/dom/message/WSSecSignature.java @@ -60,7 +60,7 @@ import org.apache.wss4j.common.util.AttachmentUtils; import org.apache.wss4j.common.util.KeyUtils; import org.apache.wss4j.common.util.XMLUtils; import org.apache.wss4j.dom.WSConstants; -import org.apache.wss4j.dom.WSDocInfo; +import org.apache.wss4j.common.dom.WSDocInfo; import org.apache.wss4j.dom.message.token.KerberosSecurity; import org.apache.wss4j.dom.transform.STRTransform; import org.apache.wss4j.dom.util.WSSecurityUtil; diff --git a/ws-security-dom/src/main/java/org/apache/wss4j/dom/message/WSSecSignatureBase.java b/ws-security-dom/src/main/java/org/apache/wss4j/dom/message/WSSecSignatureBase.java index e86575f2e..7e103c64f 100644 --- a/ws-security-dom/src/main/java/org/apache/wss4j/dom/message/WSSecSignatureBase.java +++ b/ws-security-dom/src/main/java/org/apache/wss4j/dom/message/WSSecSignatureBase.java @@ -43,7 +43,7 @@ import org.apache.wss4j.common.ext.WSSecurityException; import org.apache.wss4j.common.util.AttachmentUtils; import org.apache.wss4j.common.util.XMLUtils; import org.apache.wss4j.dom.WSConstants; -import org.apache.wss4j.dom.WSDocInfo; +import org.apache.wss4j.common.dom.WSDocInfo; import org.apache.wss4j.dom.transform.AttachmentTransformParameterSpec; import org.apache.wss4j.dom.transform.STRTransform; import org.apache.wss4j.dom.util.SignatureUtils; diff --git a/ws-security-dom/src/main/java/org/apache/wss4j/dom/processor/EncryptedKeyProcessor.java b/ws-security-dom/src/main/java/org/apache/wss4j/dom/processor/EncryptedKeyProcessor.java index 7fbf39a71..c80ffad95 100644 --- a/ws-security-dom/src/main/java/org/apache/wss4j/dom/processor/EncryptedKeyProcessor.java +++ b/ws-security-dom/src/main/java/org/apache/wss4j/dom/processor/EncryptedKeyProcessor.java @@ -63,7 +63,7 @@ import org.apache.wss4j.common.util.KeyUtils; import org.apache.wss4j.common.util.XMLUtils; import org.apache.wss4j.dom.WSConstants; import org.apache.wss4j.common.WSDataRef; -import org.apache.wss4j.dom.WSDocInfo; +import org.apache.wss4j.common.dom.WSDocInfo; import org.apache.wss4j.common.dom.engine.WSSecurityEngineResult; import org.apache.wss4j.dom.handler.RequestData; import org.apache.wss4j.dom.str.EncryptedKeySTRParser; diff --git a/ws-security-dom/src/main/java/org/apache/wss4j/dom/processor/SignatureProcessor.java b/ws-security-dom/src/main/java/org/apache/wss4j/dom/processor/SignatureProcessor.java index 8d352dd99..ee0c5a73a 100644 --- a/ws-security-dom/src/main/java/org/apache/wss4j/dom/processor/SignatureProcessor.java +++ b/ws-security-dom/src/main/java/org/apache/wss4j/dom/processor/SignatureProcessor.java @@ -64,7 +64,7 @@ import org.apache.wss4j.common.util.KeyUtils; import org.apache.wss4j.common.util.XMLUtils; import org.apache.wss4j.dom.WSConstants; import org.apache.wss4j.common.WSDataRef; -import org.apache.wss4j.dom.WSDocInfo; +import org.apache.wss4j.common.dom.WSDocInfo; import org.apache.wss4j.common.dom.engine.WSSecurityEngineResult; import org.apache.wss4j.dom.handler.RequestData; import org.apache.wss4j.dom.message.token.Timestamp; diff --git a/ws-security-dom/src/main/java/org/apache/wss4j/dom/saml/WSSecSignatureSAML.java b/ws-security-dom/src/main/java/org/apache/wss4j/dom/saml/WSSecSignatureSAML.java index deb87b079..f735bc1f8 100644 --- a/ws-security-dom/src/main/java/org/apache/wss4j/dom/saml/WSSecSignatureSAML.java +++ b/ws-security-dom/src/main/java/org/apache/wss4j/dom/saml/WSSecSignatureSAML.java @@ -48,7 +48,7 @@ import org.apache.wss4j.common.token.X509Security; import org.apache.wss4j.common.util.KeyUtils; import org.apache.wss4j.common.util.XMLUtils; import org.apache.wss4j.dom.WSConstants; -import org.apache.wss4j.dom.WSDocInfo; +import org.apache.wss4j.common.dom.WSDocInfo; import org.apache.wss4j.dom.handler.RequestData; import org.apache.wss4j.dom.message.WSSecHeader; import org.apache.wss4j.dom.message.WSSecSignature; diff --git a/ws-security-dom/src/main/java/org/apache/wss4j/dom/str/EncryptedKeySTRParser.java b/ws-security-dom/src/main/java/org/apache/wss4j/dom/str/EncryptedKeySTRParser.java index e8e823afe..4f1089fe5 100644 --- a/ws-security-dom/src/main/java/org/apache/wss4j/dom/str/EncryptedKeySTRParser.java +++ b/ws-security-dom/src/main/java/org/apache/wss4j/dom/str/EncryptedKeySTRParser.java @@ -34,7 +34,7 @@ import org.apache.wss4j.common.token.SecurityTokenReference; import org.apache.wss4j.common.token.X509Security; import org.apache.wss4j.common.util.XMLUtils; import org.apache.wss4j.dom.WSConstants; -import org.apache.wss4j.dom.WSDocInfo; +import org.apache.wss4j.common.dom.WSDocInfo; import org.apache.wss4j.common.dom.engine.WSSecurityEngineResult; import org.apache.wss4j.dom.handler.RequestData; import org.apache.wss4j.dom.saml.WSSSAMLKeyInfoProcessor; diff --git a/ws-security-dom/src/main/java/org/apache/wss4j/dom/str/STRParserUtil.java b/ws-security-dom/src/main/java/org/apache/wss4j/dom/str/STRParserUtil.java index d05a4e20b..455df0af9 100644 --- a/ws-security-dom/src/main/java/org/apache/wss4j/dom/str/STRParserUtil.java +++ b/ws-security-dom/src/main/java/org/apache/wss4j/dom/str/STRParserUtil.java @@ -37,7 +37,7 @@ import org.apache.wss4j.common.token.SecurityTokenReference; import org.apache.wss4j.common.token.X509Security; import org.apache.wss4j.common.util.XMLUtils; import org.apache.wss4j.dom.WSConstants; -import org.apache.wss4j.dom.WSDocInfo; +import org.apache.wss4j.common.dom.WSDocInfo; import org.apache.wss4j.common.dom.engine.WSSecurityEngineResult; import org.apache.wss4j.dom.handler.RequestData; import org.apache.wss4j.dom.message.token.KerberosSecurity; diff --git a/ws-security-dom/src/main/java/org/apache/wss4j/dom/str/SecurityTokenRefSTRParser.java b/ws-security-dom/src/main/java/org/apache/wss4j/dom/str/SecurityTokenRefSTRParser.java index 27cf41fca..a89e03ea7 100644 --- a/ws-security-dom/src/main/java/org/apache/wss4j/dom/str/SecurityTokenRefSTRParser.java +++ b/ws-security-dom/src/main/java/org/apache/wss4j/dom/str/SecurityTokenRefSTRParser.java @@ -36,7 +36,7 @@ import org.apache.wss4j.common.util.KeyUtils; import org.apache.wss4j.common.util.UsernameTokenUtil; import org.apache.wss4j.common.util.XMLUtils; import org.apache.wss4j.dom.WSConstants; -import org.apache.wss4j.dom.WSDocInfo; +import org.apache.wss4j.common.dom.WSDocInfo; import org.apache.wss4j.common.dom.engine.WSSecurityEngineResult; import org.apache.wss4j.dom.handler.RequestData; import org.apache.wss4j.dom.message.token.DerivedKeyToken; diff --git a/ws-security-dom/src/main/java/org/apache/wss4j/dom/str/SignatureSTRParser.java b/ws-security-dom/src/main/java/org/apache/wss4j/dom/str/SignatureSTRParser.java index a6ee6b35d..c9462ef9e 100644 --- a/ws-security-dom/src/main/java/org/apache/wss4j/dom/str/SignatureSTRParser.java +++ b/ws-security-dom/src/main/java/org/apache/wss4j/dom/str/SignatureSTRParser.java @@ -43,7 +43,7 @@ import org.apache.wss4j.common.token.SecurityTokenReference; import org.apache.wss4j.common.util.KeyUtils; import org.apache.wss4j.common.util.XMLUtils; import org.apache.wss4j.dom.WSConstants; -import org.apache.wss4j.dom.WSDocInfo; +import org.apache.wss4j.common.dom.WSDocInfo; import org.apache.wss4j.common.dom.engine.WSSecurityEngineResult; import org.apache.wss4j.dom.handler.RequestData; import org.apache.wss4j.dom.message.token.DerivedKeyToken; diff --git a/ws-security-dom/src/main/java/org/apache/wss4j/dom/transform/STRTransform.java b/ws-security-dom/src/main/java/org/apache/wss4j/dom/transform/STRTransform.java index 30adf1882..a1baa0881 100644 --- a/ws-security-dom/src/main/java/org/apache/wss4j/dom/transform/STRTransform.java +++ b/ws-security-dom/src/main/java/org/apache/wss4j/dom/transform/STRTransform.java @@ -43,7 +43,7 @@ import org.apache.wss4j.common.token.SecurityTokenReference; import org.apache.wss4j.common.token.X509Security; import org.apache.wss4j.common.util.XMLUtils; import org.apache.wss4j.dom.WSConstants; -import org.apache.wss4j.dom.WSDocInfo; +import org.apache.wss4j.common.dom.WSDocInfo; import org.apache.xml.security.c14n.Canonicalizer; import org.apache.xml.security.signature.XMLSignatureInput; import org.apache.xml.security.signature.XMLSignatureStreamInput; diff --git a/ws-security-dom/src/main/java/org/apache/wss4j/dom/transform/STRTransformUtil.java b/ws-security-dom/src/main/java/org/apache/wss4j/dom/transform/STRTransformUtil.java index 11c17729b..ae1d7b0b7 100644 --- a/ws-security-dom/src/main/java/org/apache/wss4j/dom/transform/STRTransformUtil.java +++ b/ws-security-dom/src/main/java/org/apache/wss4j/dom/transform/STRTransformUtil.java @@ -28,7 +28,7 @@ import org.apache.wss4j.common.token.SecurityTokenReference; import org.apache.wss4j.common.token.X509Security; import org.apache.wss4j.common.util.XMLUtils; import org.apache.wss4j.dom.WSConstants; -import org.apache.wss4j.dom.WSDocInfo; +import org.apache.wss4j.common.dom.WSDocInfo; import org.apache.wss4j.dom.str.STRParserUtil; import org.w3c.dom.Document; import org.w3c.dom.Element; diff --git a/ws-security-dom/src/main/java/org/apache/wss4j/dom/util/EncryptionUtils.java b/ws-security-dom/src/main/java/org/apache/wss4j/dom/util/EncryptionUtils.java index 208c80063..d73ea58ef 100644 --- a/ws-security-dom/src/main/java/org/apache/wss4j/dom/util/EncryptionUtils.java +++ b/ws-security-dom/src/main/java/org/apache/wss4j/dom/util/EncryptionUtils.java @@ -28,7 +28,7 @@ import org.apache.wss4j.common.util.AttachmentUtils; import org.apache.wss4j.common.util.XMLUtils; import org.apache.wss4j.dom.WSConstants; import org.apache.wss4j.common.WSDataRef; -import org.apache.wss4j.dom.WSDocInfo; +import org.apache.wss4j.common.dom.WSDocInfo; import org.apache.xml.security.algorithms.JCEMapper; import org.apache.xml.security.encryption.Serializer; import org.apache.xml.security.encryption.XMLCipher; diff --git a/ws-security-dom/src/main/java/org/apache/wss4j/dom/util/SignatureUtils.java b/ws-security-dom/src/main/java/org/apache/wss4j/dom/util/SignatureUtils.java index 269adc790..bf565b739 100644 --- a/ws-security-dom/src/main/java/org/apache/wss4j/dom/util/SignatureUtils.java +++ b/ws-security-dom/src/main/java/org/apache/wss4j/dom/util/SignatureUtils.java @@ -27,7 +27,7 @@ import java.util.Set; import org.apache.wss4j.common.ext.WSSecurityException; import org.apache.wss4j.dom.WSConstants; import org.apache.wss4j.common.WSDataRef; -import org.apache.wss4j.dom.WSDocInfo; +import org.apache.wss4j.common.dom.WSDocInfo; import org.apache.wss4j.common.dom.engine.WSSecurityEngineResult; import org.w3c.dom.Element; import org.w3c.dom.NamedNodeMap;