[
https://issues.apache.org/jira/browse/WICKET-7123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883848#comment-17883848
]
ASF GitHub Bot commented on WICKET-7123:
----------------------------------------
1azyman opened a new pull request, #971:
URL: https://github.com/apache/wicket/pull/971
- default form submit can now be set one per form (not form hierarchy)
- hidden input submit in root form now not needed, everything handled in JS
- click invocation mostly reused old part of javascript
- tests green
One thing that I'm missing but couldn't figure out was to write test with
form hierarchy (parent/child form) with inputs and simulate filling text field
and hitting "enter"...
> Form.setDefaultButton() supports only one button per form hierarchy
> -------------------------------------------------------------------
>
> Key: WICKET-7123
> URL: https://issues.apache.org/jira/browse/WICKET-7123
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-core
> Affects Versions: 10.1.0
> Reporter: Viliam Repan
> Priority: Major
>
> Currently Form.setDefaultButton() support only one button per whole form
> hierarchy, which is a problem when there are multiple forms on page of for
> example popup. It complicates even further when those default submit buttons
> have custom visibility/enabled state.
> Current implementation puts hidden field in root form which stores name of
> submit button and then creates client JS click() via jquery.
> This should be easy doable directly on form where the default button is
> located without the need to pass it to root form.
> What do you think about this?
> PR available here https://github.com/apache/wicket/pull/968
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
