(trafficserver) branch master updated: Zero-initialize struct variables in JA4 plugin (#11953)

[jvanderzee]

This is an automated email from the ASF dual-hosted git repository.

jvanderzee pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git


The following commit(s) were added to refs/heads/master by this push:
     new e1f49f64eb Zero-initialize struct variables in JA4 plugin (#11953)
e1f49f64eb is described below

commit e1f49f64eb2a52d27b95c71b93a4758867a5bf66
Author: JosiahWI <41302989+josia...@users.noreply.github.com>
AuthorDate: Tue Jan 14 17:09:38 2025 -0600

    Zero-initialize struct variables in JA4 plugin (#11953)
    
    This should appease the compiler's warning checker and ensure that the 
structs are always initialized.
    
    Fixes #11952.
---
 plugins/experimental/ja4_fingerprint/plugin.cc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/plugins/experimental/ja4_fingerprint/plugin.cc 
b/plugins/experimental/ja4_fingerprint/plugin.cc
index 7c31dd45ab..711f53d781 100644
--- a/plugins/experimental/ja4_fingerprint/plugin.cc
+++ b/plugins/experimental/ja4_fingerprint/plugin.cc
@@ -95,7 +95,7 @@ get_log_handle()
 static constexpr TSPluginRegistrationInfo
 get_registration_info()
 {
-  TSPluginRegistrationInfo info;
+  TSPluginRegistrationInfo info{};
   info.plugin_name   = PLUGIN_NAME;
   info.vendor_name   = PLUGIN_VENDOR;
   info.support_email = PLUGIN_SUPPORT_EMAIL;
@@ -179,7 +179,7 @@ handle_client_hello(TSCont /* cont ATS_UNUSED */, TSEvent 
event, void *edata)
 std::string
 get_fingerprint(SSL *ssl)
 {
-  JA4::TLSClientHelloSummary summary;
+  JA4::TLSClientHelloSummary summary{};
   summary.protocol    = JA4::Protocol::TLS;
   summary.TLS_version = get_version(ssl);
   summary.ALPN        = get_first_ALPN(ssl);