(trafficserver) branch master updated: Coverity: Fix for CID-1528689 (#11876)

[dmeden]

This is an automated email from the ASF dual-hosted git repository.

dmeden pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git


The following commit(s) were added to refs/heads/master by this push:
     new 88d241a177 Coverity: Fix for CID-1528689 (#11876)
88d241a177 is described below

commit 88d241a1770fb16d1f1c7ddcfd792eabe48c57a5
Author: Damian Meden <dme...@apache.org>
AuthorDate: Tue Nov 19 10:00:31 2024 +0100

    Coverity: Fix for CID-1528689 (#11876)
---
 src/traffic_ctl/CtrlPrinters.cc | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/src/traffic_ctl/CtrlPrinters.cc b/src/traffic_ctl/CtrlPrinters.cc
index 72dfc53d46..8f42e72f41 100644
--- a/src/traffic_ctl/CtrlPrinters.cc
+++ b/src/traffic_ctl/CtrlPrinters.cc
@@ -42,16 +42,13 @@ namespace
 void
 
print_record_error_list(std::vector<shared::rpc::RecordLookUpResponse::RecordError>
 const &errors)
 {
-  if (errors.size()) {
+  if (auto iter = std::begin(errors); iter != std::end(errors)) {
     std::cout << "------------ Errors ----------\n";
-    auto iter = std::begin(errors);
-    if (iter != std::end(errors)) {
-      std::cout << *iter;
-    }
+    std::cout << *iter;
     ++iter;
-    for (auto err = iter; err != std::end(errors); ++err) {
+    for (; iter != std::end(errors); ++iter) {
       std::cout << "--\n";
-      std::cout << *err;
+      std::cout << *iter;
     }
   }
 }