(trafficserver) branch master updated: Coverity: txn_box, fix a few copy instead of move warnings. (#11800)

[dmeden]

This is an automated email from the ASF dual-hosted git repository.

dmeden pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git


The following commit(s) were added to refs/heads/master by this push:
     new cc8e6ed5ad Coverity: txn_box, fix a few copy instead of move warnings. 
(#11800)
cc8e6ed5ad is described below

commit cc8e6ed5ad5d19c5244147545fb50d61f19fe7c7
Author: Damian Meden <dme...@apache.org>
AuthorDate: Wed Oct 2 09:27:50 2024 +0200

    Coverity: txn_box, fix a few copy instead of move warnings. (#11800)
    
    CID-1534703
    CID-1534707
    CID-1534708
    CID-1534713
---
 plugins/experimental/txn_box/plugin/src/Config.cc     | 2 +-
 plugins/experimental/txn_box/plugin/src/Modifier.cc   | 4 ++--
 plugins/experimental/txn_box/plugin/src/text_block.cc | 2 +-
 plugins/experimental/txn_box/plugin/src/txn_box.cc    | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/plugins/experimental/txn_box/plugin/src/Config.cc 
b/plugins/experimental/txn_box/plugin/src/Config.cc
index c70ee1527f..3e5f9dca02 100644
--- a/plugins/experimental/txn_box/plugin/src/Config.cc
+++ b/plugins/experimental/txn_box/plugin/src/Config.cc
@@ -758,7 +758,7 @@ Config::load_cli_args(Handle handle, const 
std::vector<std::string> &args, int a
   for (auto const &arg : args) {
     argv[idx++] = arg.c_str();
   }
-  return this->load_cli_args(handle, argv, arg_idx, cache);
+  return this->load_cli_args(std::move(handle), argv, arg_idx, cache);
 }
 
 Errata
diff --git a/plugins/experimental/txn_box/plugin/src/Modifier.cc 
b/plugins/experimental/txn_box/plugin/src/Modifier.cc
index 91b11e1218..cfef23a0fa 100644
--- a/plugins/experimental/txn_box/plugin/src/Modifier.cc
+++ b/plugins/experimental/txn_box/plugin/src/Modifier.cc
@@ -991,9 +991,9 @@ Mod_as_integer::operator()(Context &ctx, Feature &feature)
   if (errata.is_ok()) {
     return Feature{value};
   }
-  auto invalid{ctx.extract(_value)};
+
   if (errata.is_ok()) {
-    return Feature{invalid};
+    return Feature{ctx.extract(_value)};
   }
   return feature;
 }
diff --git a/plugins/experimental/txn_box/plugin/src/text_block.cc 
b/plugins/experimental/txn_box/plugin/src/text_block.cc
index 0d09a1920c..dc6e341395 100644
--- a/plugins/experimental/txn_box/plugin/src/text_block.cc
+++ b/plugins/experimental/txn_box/plugin/src/text_block.cc
@@ -304,7 +304,7 @@ Do_text_block_define::Updater::operator()()
     if (!ec) { // swap in updated content.
       {
         std::unique_lock lock(_block->_content_mutex);
-        _block->_content       = content;
+        _block->_content       = std::move(content);
         _block->_last_modified = mtime;
       }
       if (_block->_notify_idx != FeatureGroup::INVALID_IDX) {
diff --git a/plugins/experimental/txn_box/plugin/src/txn_box.cc 
b/plugins/experimental/txn_box/plugin/src/txn_box.cc
index 90a3abce92..ba976c9a0a 100644
--- a/plugins/experimental/txn_box/plugin/src/txn_box.cc
+++ b/plugins/experimental/txn_box/plugin/src/txn_box.cc
@@ -127,7 +127,7 @@ Task_ConfigReload()
     auto            errata = cfg->load_cli_args(cfg, G._args, 1);
     if (errata.is_ok()) {
       std::unique_lock lock(Plugin_Config_Mutex);
-      Plugin_Config = cfg;
+      Plugin_Config = std::move(cfg);
     } else {
       std::string err_str;
       swoc::bwprint(err_str, "{}: Failed to reload configuration.\n{}", 
Config::PLUGIN_NAME, errata);