This is an automated email from the ASF dual-hosted git repository.
bneradt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git
The following commit(s) were added to refs/heads/master by this push:
new 43da036d8e ja3_fingerprint.test.py: address race condition (#11766)
43da036d8e is described below
commit 43da036d8e7aded6d3ecb4129cfef7ffee2085e5
Author: Brian Neradt <[email protected]>
AuthorDate: Thu Sep 12 12:57:00 2024 -0500
ja3_fingerprint.test.py: address race condition (#11766)
ja3_fingerprint.test.py uses the Proxy Verifier client and configures it
with two sessions/connections. By default, Proxy Verifier will run the
transactions for those two connections in parallel. Generally the first
HTTP/1 session will finish before the second HTTP/2 session, but
sometimes the second session finished first. That causes the test to
fail because the gold file expects the other order. This patch addresses
this race condition issue by simply configuring the client to run the
sessions in serial rather than in parallel.
---
tests/gold_tests/pluginTest/ja3_fingerprint/ja3_fingerprint.test.py | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git
a/tests/gold_tests/pluginTest/ja3_fingerprint/ja3_fingerprint.test.py
b/tests/gold_tests/pluginTest/ja3_fingerprint/ja3_fingerprint.test.py
index e592593f43..6032509a6a 100644
--- a/tests/gold_tests/pluginTest/ja3_fingerprint/ja3_fingerprint.test.py
+++ b/tests/gold_tests/pluginTest/ja3_fingerprint/ja3_fingerprint.test.py
@@ -134,7 +134,11 @@ class JA3FingerprintTest:
"""
name = f'client{self._client_counter}'
p = tr.AddVerifierClientProcess(
- name, self._replay_file, http_ports=[self._ts.Variables.port],
https_ports=[self._ts.Variables.ssl_port])
+ name,
+ self._replay_file,
+ http_ports=[self._ts.Variables.port],
+ https_ports=[self._ts.Variables.ssl_port],
+ other_args='--thread-limit 1')
JA3FingerprintTest._client_counter += 1
p.StartBefore(self._dns)
