This is an automated email from the ASF dual-hosted git repository. cmcfarlen pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/trafficserver.git
commit 22671842ce36b0ced1373742b69b9f3220bca3bd Author: Damian Meden <[email protected]> AuthorDate: Thu Mar 7 10:21:36 2024 +0100 Coverity fixes. CID 1534726 , CID 1534745, CID1534723 (#11111) - CID 1534726 COPY_INSTEAD_OF_MOVE (COPY_INSTEAD_OF_MOVE) - CID 1534745 COPY_INSTEAD_OF_MOVE (COPY_INSTEAD_OF_MOVE) - CID1534723 (cherry picked from commit bfde4098870e1734b749c453aecc2879119fc2fd) --- plugins/experimental/txn_box/plugin/include/txn_box/accl_util.h | 2 +- plugins/experimental/txn_box/unit_tests/CMakeLists.txt | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/plugins/experimental/txn_box/plugin/include/txn_box/accl_util.h b/plugins/experimental/txn_box/plugin/include/txn_box/accl_util.h index c45614ce80..14c306e2b0 100644 --- a/plugins/experimental/txn_box/plugin/include/txn_box/accl_util.h +++ b/plugins/experimental/txn_box/plugin/include/txn_box/accl_util.h @@ -65,7 +65,7 @@ template <typename Key, typename Value> class StringTree using self_type = Node; using ptr_type = self_type *; - Node(Key k, Value v, int32_t r = -1) : key{k}, value{v}, rank{r} + Node(Key k, Value v, int32_t r = -1) : key{std::move(k)}, value{std::move(v)}, rank{r} { left = this; right = this; diff --git a/plugins/experimental/txn_box/unit_tests/CMakeLists.txt b/plugins/experimental/txn_box/unit_tests/CMakeLists.txt index cc20499658..02665ca8e7 100644 --- a/plugins/experimental/txn_box/unit_tests/CMakeLists.txt +++ b/plugins/experimental/txn_box/unit_tests/CMakeLists.txt @@ -28,7 +28,5 @@ target_link_libraries( ) # After fighting with CMake over the include paths, it's just not worth it to be correct. # target_link_libraries should make this work but it doesn't. I can't figure out why. -# target_include_directories(test_txn_box PRIVATE ../../plugin/include) target_include_directories(test_txn_box PUBLIC ${CMAKE_CURRENT_SOURCE_DIR}/../plugin/include) -# target_include_directories(test_txn_box PRIVATE ../../plugin/include ${trafficserver_INCLUDE_DIRS}) add_test(NAME test_txn_box COMMAND test_txn_box)
