(incubator-toree) branch master updated: Fix check-licenses script bugs (#233)

[lresende]

This is an automated email from the ASF dual-hosted git repository.

lresende pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-toree.git


The following commit(s) were added to refs/heads/master by this push:
     new 83f60679 Fix check-licenses script bugs (#233)
83f60679 is described below

commit 83f60679462e484c4232005b4ffc8c588b56313a
Author: Ed Espino <esp...@apache.org>
AuthorDate: Sat Nov 8 09:06:46 2025 -0800

    Fix check-licenses script bugs (#233)
    
    This commit fixes two bugs in the check-licenses script:
    
    1. Removed unnecessary and buggy 'mkdir -p "$FWDIR"etc/tools/' on
       line 63. The etc/tools directory already exists in the repository
       (it contains this script). The command also had a path concatenation
       bug with a missing '/' separator that would create a phantom
       directory like 'toree-0.6.0-incubating-srcetc' in the parent
       directory.
    
    2. Added 'mkdir -p target' before writing rat-results.txt. This
       ensures the script works when running 'make auto-licenses' in a
       clean checkout without requiring a prior build to create the
       target directory.
---
 etc/tools/check-licenses | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/etc/tools/check-licenses b/etc/tools/check-licenses
index 5941c43a..679be6b1 100755
--- a/etc/tools/check-licenses
+++ b/etc/tools/check-licenses
@@ -60,13 +60,13 @@ fi
 
 export RAT_VERSION=0.12
 export rat_jar="$FWDIR"/etc/tools/apache-rat-${RAT_VERSION}.jar
-mkdir -p "$FWDIR"etc/tools/
 
 [[ -f "$rat_jar" ]] || acquire_rat_jar || {
     echo "Download failed. Obtain the rat jar manually and place it at 
$rat_jar"
     exit 1
 }
 
+mkdir -p target
 $java_cmd -jar "$rat_jar" -E "$FWDIR"/etc/tools/.rat-excludes -d "$FWDIR" > 
target/rat-results.txt
 
 if [ $? -ne 0 ]; then