The GitHub Actions job "Required Checks" on texera.git/main has failed.
Run started by GitHub user github-merge-queue[bot] (triggered by 
github-merge-queue[bot]).

Head commit for run:
6becb8596df32058f69473c39f4a9028f149954e / Kyle Yin Xu 
<[email protected]>
test(workflow-operator): add ImageUtilitySpec for encodeImageToHTML (#5679)

<!--
Thanks for sending a pull request (PR)! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
[Contributing to
Texera](https://github.com/apache/texera/blob/main/CONTRIBUTING.md)
  2. Ensure you have added or run the appropriate tests for your PR
  3. If the PR is work in progress, mark it a draft on GitHub.
  4. Please write your PR title to summarize what this PR proposes, we 
    are following Conventional Commits style for PR titles as well.
  5. Be sure to keep the PR description updated to reflect all changes.
-->

### What changes were proposed in this PR?

Pin the Python snippet emitted by ImageUtility.encodeImageToHTML() — the
helper that visualization operators splice into generated UDF code to
base64-encode binary image data into an <img> tag. Any drift in the
f-string template or the error fallback would silently break
image-rendering operators (e.g. Word Cloud). No production-code changes.
Negative cases are covered implicitly: removing any pinned substring
fails the corresponding assertion.

| Spec | Source Class | Tests |
| --- | --- | --- |
| ImageUtilitySpec | ImageUtility | 8 |

Spec file name follows the `<srcClassName>Spec.scala` one-to-one
convention.

**Behavior pinned**

| Surface | Contract |
| :--- | :--- |
| `encodeImageToHTML` | returns a non-empty `String` |
| Snippet imports base64 | substring `import base64` appears |
| Snippet calls `base64.b64encode(binary_image_data)` | substring
appears verbatim |
| Snippet decodes to UTF-8 | substring `.decode("utf-8")` appears |
| Snippet emits an `<img>` tag with `data:image;base64,...` | substring
`data:image;base64,{encoded_image_str}` appears (verifies the f-string
template) |
| Snippet handles binary-decode failure via try/except | substrings
`except Exception` and `Binary input is not valid` both appear |
| Snippet contains a top-level `html =` assignment | substring `html =
f` appears so downstream code can reference `html` |
| Determinism | two calls return the exact same string |

The harness pins via `contains` on canonical substrings — resilient to
incidental whitespace changes from `stripMargin` while still catching
real template drift.
### Any related issues, documentation, discussions?
<!--
Please use this section to link other resources if not mentioned
already.
1. If this PR fixes an issue, please include `Fixes #1234`, `Resolves
#1234`
or `Closes #1234`. If it is only related, simply mention the issue
number.
  2. If there is design documentation, please add the link.
  3. If there is a discussion in the mailing list, please add the link.
-->
Closes #5665 

### How was this PR tested?
<!--
If tests were added, say they were added here. Or simply mention that if
the PR
is tested with existing test cases. Make sure to include/update test
cases that
check the changes thoroughly including negative and positive cases if
possible.
If it was tested in a way different from regular unit tests, please
clarify how
you tested step by step, ideally copy and paste-able, so that other
reviewers can
test and check, and descendants can verify in the future. If tests were
not added,
please describe why they were not added and/or why it was difficult to
add.
-->
Unit tests were added here, tested through local verification:

- ```sbt "WorkflowOperator/testOnly
org.apache.texera.amber.operator.visualization.ImageUtilitySpec"``` -
All 8 tests passed
- ```sbt scalafmtCheckAll``` -- clean
- ```sbt scalafixAll --check``` No lint errors

### Was this PR authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this
PR,
please include the phrase: 'Generated-by: ' followed by the name of the
tool
and its version. If no, write 'No'. 
Please refer to the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) for
details.
-->
Generated-by: Composer 2.5 Fast

Report URL: https://github.com/apache/texera/actions/runs/27474958597

With regards,
GitHub Actions via GitBox

Reply via email to