This is an automated email from the ASF dual-hosted git repository.
kunwp1 pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/texera.git
The following commit(s) were added to refs/heads/main by this push:
new a7c33414fe fix: initialize large-binary S3 bucket at startup to
prevent NoSuchBucketException (#4241)
a7c33414fe is described below
commit a7c33414fe48337eae74f1bce87c95c50d87b32a
Author: Kunwoo (Chris) <[email protected]>
AuthorDate: Thu Mar 19 10:34:23 2026 -0700
fix: initialize large-binary S3 bucket at startup to prevent
NoSuchBucketException (#4241)
<!--
Thanks for sending a pull request (PR)! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
[Contributing to
Texera](https://github.com/apache/texera/blob/main/CONTRIBUTING.md)
2. Ensure you have added or run the appropriate tests for your PR
3. If the PR is work in progress, mark it a draft on GitHub.
4. Please write your PR title to summarize what this PR proposes, we
are following Conventional Commits style for PR titles as well.
5. Be sure to keep the PR description updated to reflect all changes.
-->
### What changes were proposed in this PR?
<!--
Please clarify what changes you are proposing. The purpose of this
section
is to outline the changes. Here are some tips for you:
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
3. If it is a refactoring, clarify what has been changed.
3. It would be helpful to include a before-and-after comparison using
screenshots or GIFs.
4. Please consider writing useful notes for better and faster reviews.
-->
Previously, the `texera-large-binaries` S3 bucket was created lazily
(only when a workflow first used a `large-binary` operator). If no
`large-binary` had ever been used, the bucket would not exist. This
caused a NoSuchBucketException warning every time
`WorkflowService.clearExecutionResources` ran at workflow
initialization, since it unconditionally attempted to delete objects
from the bucket.
This fix mirrors the existing pattern used for the dataset bucket in
`FileService`. The `S3StorageClient.createBucketIfNotExist` is now
called once during `FileService` startup, ensuring the bucket always
exists before any workflow execution or cleanup is attempted. The
redundant per-call `createBucketIfNotExist` that was previously inside
`LargeBinaryManager.create()` has also been removed, as it is no longer
needed.
### Any related issues, documentation, discussions?
<!--
Please use this section to link other resources if not mentioned
already.
1. If this PR fixes an issue, please include `Fixes #1234`, `Resolves
#1234`
or `Closes #1234`. If it is only related, simply mention the issue
number.
2. If there is design documentation, please add the link.
3. If there is a discussion in the mailing list, please add the link.
-->
Fixes #4239
### How was this PR tested?
<!--
If tests were added, say they were added here. Or simply mention that if
the PR
is tested with existing test cases. Make sure to include/update test
cases that
check the changes thoroughly including negative and positive cases if
possible.
If it was tested in a way different from regular unit tests, please
clarify how
you tested step by step, ideally copy and paste-able, so that other
reviewers can
test and check, and descendants can verify in the future. If tests were
not added,
please describe why they were not added and/or why it was difficult to
add.
-->
Check if the error message disappears after running any workflow
### Was this PR authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this
PR,
please include the phrase: 'Generated-by: ' followed by the name of the
tool
and its version. If no, write 'No'.
Please refer to the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) for
details.
-->
Claude-4.6
---
.../scala/org/apache/texera/service/util/LargeBinaryManager.scala | 4 +---
.../src/main/scala/org/apache/texera/service/FileService.scala | 3 +++
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git
a/common/workflow-core/src/main/scala/org/apache/texera/service/util/LargeBinaryManager.scala
b/common/workflow-core/src/main/scala/org/apache/texera/service/util/LargeBinaryManager.scala
index 211d7d3b75..b23edb7ae9 100644
---
a/common/workflow-core/src/main/scala/org/apache/texera/service/util/LargeBinaryManager.scala
+++
b/common/workflow-core/src/main/scala/org/apache/texera/service/util/LargeBinaryManager.scala
@@ -30,7 +30,7 @@ import java.util.UUID
* normal tuple size limits.
*/
object LargeBinaryManager extends LazyLogging {
- private val DEFAULT_BUCKET = "texera-large-binaries"
+ val DEFAULT_BUCKET: String = "texera-large-binaries"
/**
* Creates a new LargeBinary reference.
@@ -39,8 +39,6 @@ object LargeBinaryManager extends LazyLogging {
* @return S3 URI string for the new LargeBinary (format: s3://bucket/key)
*/
def create(): String = {
- S3StorageClient.createBucketIfNotExist(DEFAULT_BUCKET)
-
val objectKey =
s"objects/${System.currentTimeMillis()}/${UUID.randomUUID()}"
val uri = s"s3://$DEFAULT_BUCKET/$objectKey"
diff --git
a/file-service/src/main/scala/org/apache/texera/service/FileService.scala
b/file-service/src/main/scala/org/apache/texera/service/FileService.scala
index 20bb242bc1..cc4174682f 100644
--- a/file-service/src/main/scala/org/apache/texera/service/FileService.scala
+++ b/file-service/src/main/scala/org/apache/texera/service/FileService.scala
@@ -38,6 +38,7 @@ import org.apache.texera.service.resource.{
HealthCheckResource
}
import org.apache.texera.service.util.S3StorageClient
+import org.apache.texera.service.util.LargeBinaryManager
import org.eclipse.jetty.server.session.SessionHandler
import java.nio.file.Path
@@ -70,6 +71,8 @@ class FileService extends
Application[FileServiceConfiguration] with LazyLogging
// check if the texera dataset bucket exists, if not create it
S3StorageClient.createBucketIfNotExist(StorageConfig.lakefsBucketName)
+ // ensure the large-binary S3 bucket exists before any workflow execution
attempts to use it
+ S3StorageClient.createBucketIfNotExist(LargeBinaryManager.DEFAULT_BUCKET)
// check if we can connect to the lakeFS service
LakeFSStorageClient.healthCheck()
