[ 
https://issues.apache.org/jira/browse/TAP5-2809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17958623#comment-17958623
 ] 

Hudson commented on TAP5-2809:
------------------------------

FAILURE: Integrated in Jenkins build Tapestry » TAP5-2809 #3 (See 
[https://ci-builds.apache.org/job/Tapestry/job/TAP5-2809/3/])
TAP5-2809: Fix sourcesJar task (benw: rev 
bdee23e17d08a7c68176feeadf4794c4c0bdcd0c)
* (edit) buildSrc/src/main/groovy/tapestry.java-convention.gradle
* (edit) beanmodel/build.gradle
TAP5-2809: set language to en for all testing (benw: rev 
5a97efc59287203f44318d32226dc5caf31d8888)
* (edit) buildSrc/src/main/groovy/tapestry.testing-base-convention.gradle
TAP5-2809: Fix continiousIntegration task (benw: rev 
6e924bf42a5508c74dbd21ef187529712d9c700d)
* (edit) build.gradle
TAP5-2809: tapestry-core build.gradle improved (benw: rev 
dd0a174b1153bb56c3fdc53cd2b1266288f5d3b7)
* (edit) tapestry-core/build.gradle
TAP5-2809: Fix Javadoc errors (benw: rev 
7f33bae39dc1d1b79e868e91a193f87a617e2600)
* (edit) 
tapestry-ioc-junit/src/main/java/org/apache/tapestry5/ioc/junit/Registry.java
* (edit) 
tapestry-ioc-junit/src/main/java/org/apache/tapestry5/ioc/junit/ModuleDef.java
* (edit) 
tapestry-ioc-junit/src/main/java/org/apache/tapestry5/ioc/junit/RegistryShutdownType.java
TAP5-2809: Fix Javadoc warnings (benw: rev 
ebb298eea08e8ad0566fb976ccf1c848b9a28894)
* (edit) 
tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/ValidatingOrderedConfigurationWrapper.java
* (edit) 
tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/cron/CronExpression.java
* (edit) 
tapestry-core/src/main/java/org/apache/tapestry5/services/javascript/JavaScriptSupport.java
* (edit) 
tapestry-core/src/main/java/org/apache/tapestry5/services/javascript/JavaScriptStack.java
* (edit) 
tapestry-core/src/main/java/org/apache/tapestry5/internal/services/DocumentLinker.java
* (edit) 
tapestry-core/src/main/java/org/apache/tapestry5/internal/services/ajax/AjaxFormUpdateController.java
* (edit) 
tapestry-http/src/main/java/org/apache/tapestry5/http/internal/services/DefaultCorsHandler.java
* (edit) 
tapestry-core/src/main/java/org/apache/tapestry5/services/ajax/AjaxResponseRenderer.java
* (edit) 
tapestry-rest-jackson/src/main/java/org/apache/tapestry5/jacksondatabind/services/ObjectMapperSource.java
* (edit) 
tapestry-core/src/main/java/org/apache/tapestry5/services/ComponentEventRequestFilter.java


> Improve/Fix Gradle Setup
> ------------------------
>
>                 Key: TAP5-2809
>                 URL: https://issues.apache.org/jira/browse/TAP5-2809
>             Project: Tapestry 5
>          Issue Type: Task
>    Affects Versions: 5.9.1
>            Reporter: Ben Weidig
>            Assignee: Ben Weidig
>            Priority: Major
>
> The current Gradle setup has multiple issues:
>  * Pre-Java 8 remnants
>  * Incomplete upgrade to JUnit 5
>  * Incorrect testng.xml
>  * Misaligned dependency version between projects
>  
> To improve the situation, I suggest:
>  * Remove all pre-Java 8 options
>  * Create Gradle conventions for
>  ** Subproject setup
>  ** JUnit 5 (+Spock)
>  ** TestNG (and move testng.xml to default locations)
>  ** JUnit 4 for legacy reasons
>  * Introducing version catalogs for shared dependencies and a consistent 
> declaration of module-specific dependencies.
>  
> In a second step, more tasks, like Javadoc-related tasks or publishing, could 
> be done with conventions or build plugins, to make them easier to use and 
> maintain.
> The overall risk is breaking the build and breaking changes for Tapestry 
> users if a dependency is no longer exposed.
> However, choosing the right configuration so as not to accidentally export 
> dependencies is more critical, and the error messages should clearly state 
> why a build is no longer working.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to