Ben Weidig created TAP5-2761: -------------------------------- Summary: ResourceStreamer#streamResource(Resource, String, Set) throws NPE if providedChecksum is null Key: TAP5-2761 URL: https://issues.apache.org/jira/browse/TAP5-2761 Project: Tapestry 5 Issue Type: Bug Components: tapestry-core Affects Versions: 5.8.3 Reporter: Ben Weidig
The documentation of {{org.apache.tapestry5.internal.services.ResourceStreamer.streamResource(Resource, String, Set<Options>)}} states it accepts {{null}} for its second argument ({{providedChecksum}}, but it doesn't. The {{org.apache.tapestry5.internal.services.ResourceStreamerImpl.streamResource(StreamableResource, String, Set<Options>)}}, however, states that {{providedChecksum}} is allowed to be blank. The term "blank" can be understood in different ways: * Tools like Apache StringUtils interpret blank as "null or whitespace only" * Java's {{String}} class has a {{isBlank()}}, which obviously requires the instance to exist To make the behavior more obvious, the documentation should state "null or blank", and the underlying code should handle it accordingly. -- This message was sent by Atlassian Jira (v8.20.10#820010)