Author: hartmannathan
Date: Tue Jun  4 01:50:29 2024
New Revision: 1918139

URL: http://svn.apache.org/viewvc?rev=1918139&view=rev
Log:
Fix unbounded memory usage in the `svn proplist --xml` command.

* subversion/svn/proplist-cmd.c:
  (proplist_receiver_xml): Invoke the svn_pool_clear function on every
   iteration to clear the iterpool.

See dev@ message on 28 May 2024:
"[PATCH] Fix unbounded memory usage in `svn proplist --xml` command."
archived:
https://lists.apache.org/thread/rqzyhvkof585gh3lnnmz4k6k48cc8f6r

Patch by: Timofey Zhakov (tima {at} chemodax _dot_ net)

Review by: hartmannathan

Modified:
    subversion/trunk/subversion/svn/proplist-cmd.c

Modified: subversion/trunk/subversion/svn/proplist-cmd.c
URL: 
http://svn.apache.org/viewvc/subversion/trunk/subversion/svn/proplist-cmd.c?rev=1918139&r1=1918138&r2=1918139&view=diff
==============================================================================
--- subversion/trunk/subversion/svn/proplist-cmd.c (original)
+++ subversion/trunk/subversion/svn/proplist-cmd.c Tue Jun  4 01:50:29 2024
@@ -75,6 +75,8 @@ proplist_receiver_xml(void *baton,
           svn_prop_inherited_item_t *iprop =
             APR_ARRAY_IDX(inherited_props, i, svn_prop_inherited_item_t *);
 
+          svn_pool_clear(iterpool);
+
           sb = NULL;
 
           if (svn_path_is_url(iprop->path_or_url))


Reply via email to