Author: futatuki
Revision: 1884279
Modified property: svn:log
Modified: svn:log at Sat Dec 12 16:33:37 2020
------------------------------------------------------------------------------
--- svn:log (original)
+++ svn:log Sat Dec 12 16:33:37 2020
@@ -1,14 +1,15 @@
-Ensure close file descriptors by using context manager in test suite.
+test suite: Ensure file descriptors are closed in a timely manner,
+using context manager
Generally, it is true that as file descriptors are closed when their
underlying objects are deleted, we don't need close them explicitly.
-However if a Python language implementation that uses other strategy
-than reference count model, there is no warranty it will happen
+However if a Python language implementation uses a strategy other
+than reference counting, there is no warranty it will happen
immediately after when those objects lose the last reference. So we
use context manager to ensure close() is called immediately after
those objects to be unnecessary. This helps us to run 'make check'
-with PyPy even smaler limit of number of open files, although we
-don't recommend use it because it is much slower than CPython for
+with PyPy under an even lower limit of number of open files, although we
+don't recommend to use PyPy because PyPy is much slower than CPython for
this purpose.
* build/run_tests.py
@@ -33,3 +34,6 @@ this purpose.
* subversion/tests/cmdline/svntest/wc.py
(State.from_wc): Use context manager to read file contents.
+
+Review by: danielsh
+ (log logmessage only)
