(struts) 01/05: WW-5440 Deprecate AnnotationParameterFilterInterceptor

[kusal]

This is an automated email from the ASF dual-hosted git repository.

kusal pushed a commit to branch WW-5440-convention
in repository https://gitbox.apache.org/repos/asf/struts.git

commit 56c1291d2fe718dd40062d39fa3ec4f05efbac1d
Author: Kusal Kithul-Godage <g...@kusal.io>
AuthorDate: Sat Jul 13 21:21:52 2024 +1000

    WW-5440 Deprecate AnnotationParameterFilterInterceptor
---
 .../com/opensymphony/xwork2/interceptor/annotations/Allowed.java   | 2 ++
 .../annotations/AnnotationParameterFilterInterceptor.java          | 7 +++++--
 .../xwork2/interceptor/annotations/BlockByDefault.java             | 2 ++
 .../com/opensymphony/xwork2/interceptor/annotations/Blocked.java   | 2 ++
 4 files changed, 11 insertions(+), 2 deletions(-)

diff --git 
a/core/src/main/java/com/opensymphony/xwork2/interceptor/annotations/Allowed.java
 
b/core/src/main/java/com/opensymphony/xwork2/interceptor/annotations/Allowed.java
index 40c6bdbbd..39bfdcb26 100644
--- 
a/core/src/main/java/com/opensymphony/xwork2/interceptor/annotations/Allowed.java
+++ 
b/core/src/main/java/com/opensymphony/xwork2/interceptor/annotations/Allowed.java
@@ -28,9 +28,11 @@ import java.lang.annotation.Target;
  * a HttpRequest parameter.
  *
  * @author martin.gilday
+ * @deprecated since 6.6.0, use {@link 
org.apache.struts2.interceptor.parameter.StrutsParameter}.
  */
 @Retention(RetentionPolicy.RUNTIME)
 @Target(ElementType.FIELD)
+@Deprecated
 public @interface Allowed {
 
 }
diff --git 
a/core/src/main/java/com/opensymphony/xwork2/interceptor/annotations/AnnotationParameterFilterInterceptor.java
 
b/core/src/main/java/com/opensymphony/xwork2/interceptor/annotations/AnnotationParameterFilterInterceptor.java
index 8309d61d2..d1b7260ac 100644
--- 
a/core/src/main/java/com/opensymphony/xwork2/interceptor/annotations/AnnotationParameterFilterInterceptor.java
+++ 
b/core/src/main/java/com/opensymphony/xwork2/interceptor/annotations/AnnotationParameterFilterInterceptor.java
@@ -23,13 +23,13 @@ import com.opensymphony.xwork2.ActionInvocation;
 import com.opensymphony.xwork2.interceptor.AbstractInterceptor;
 import com.opensymphony.xwork2.interceptor.Interceptor;
 import com.opensymphony.xwork2.interceptor.ParameterFilterInterceptor;
-import com.opensymphony.xwork2.interceptor.ParametersInterceptor;
 import com.opensymphony.xwork2.util.AnnotationUtils;
 import org.apache.struts2.dispatcher.HttpParameters;
+import org.apache.struts2.interceptor.parameter.ParametersInterceptor;
+import org.apache.struts2.interceptor.parameter.StrutsParameter;
 
 import java.lang.reflect.Field;
 import java.util.ArrayList;
-import java.util.HashSet;
 import java.util.List;
 
 /**
@@ -46,7 +46,10 @@ import java.util.List;
  * </p>
  *
  * @author martin.gilday
+ * @deprecated since 6.6.0, integrated into {@link ParametersInterceptor} with 
{@link StrutsParameter} using
+ * {@code struts.parameters.requireAnnotations=true}
  */
+@Deprecated
 public class AnnotationParameterFilterInterceptor extends AbstractInterceptor {
 
     /* (non-Javadoc)
diff --git 
a/core/src/main/java/com/opensymphony/xwork2/interceptor/annotations/BlockByDefault.java
 
b/core/src/main/java/com/opensymphony/xwork2/interceptor/annotations/BlockByDefault.java
index ddb855b3d..e7b452022 100644
--- 
a/core/src/main/java/com/opensymphony/xwork2/interceptor/annotations/BlockByDefault.java
+++ 
b/core/src/main/java/com/opensymphony/xwork2/interceptor/annotations/BlockByDefault.java
@@ -31,9 +31,11 @@ import java.lang.annotation.Target;
  * To allow access to a field it must be annotated with {@link Allowed}
  *
  * @author martin.gilday
+ * @deprecated since 6.6.0, use {@code 
struts.parameters.requireAnnotations=true} to block all parameters globally.
  */
 @Retention(RetentionPolicy.RUNTIME)
 @Target(ElementType.TYPE)
+@Deprecated
 public @interface BlockByDefault {
 
 }
diff --git 
a/core/src/main/java/com/opensymphony/xwork2/interceptor/annotations/Blocked.java
 
b/core/src/main/java/com/opensymphony/xwork2/interceptor/annotations/Blocked.java
index 630368a87..17ec80940 100644
--- 
a/core/src/main/java/com/opensymphony/xwork2/interceptor/annotations/Blocked.java
+++ 
b/core/src/main/java/com/opensymphony/xwork2/interceptor/annotations/Blocked.java
@@ -28,9 +28,11 @@ import java.lang.annotation.Target;
  * a HttpRequest parameter.
  *
  * @author martin.gilday
+ * @deprecated since 6.6.0, use {@code 
struts.parameters.requireAnnotations=true} to block all parameters globally.
  */
 @Retention(RetentionPolicy.RUNTIME)
 @Target(ElementType.FIELD)
+@Deprecated
 public @interface Blocked {
 
 }