This is an automated email from the ASF dual-hosted git repository. kusal pushed a commit to branch WW-5343-sec-extend in repository https://gitbox.apache.org/repos/asf/struts.git
commit 9e556e9ed4a49f358c692ea955e2150842a10f3e Author: Kusal Kithul-Godage <g...@kusal.io> AuthorDate: Wed Nov 15 00:20:58 2023 +1100 WW-5343 Deprecate unnecessary setter --- .../main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java b/core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java index 90846f5fe..a003972d5 100644 --- a/core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java +++ b/core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java @@ -115,6 +115,7 @@ public class OgnlValueStack implements Serializable, ValueStack, ClearableValueS this.root = compoundRoot; this.securityMemberAccess = new SecurityMemberAccess(allowStaticFieldAccess); this.context = Ognl.createDefaultContext(this.root, securityMemberAccess, accessor, new OgnlTypeConverterWrapper(xworkConverter)); + this.converter = xworkConverter; context.put(VALUE_STACK, this); ((OgnlContext) context).setTraceEvaluations(false); ((OgnlContext) context).setKeepLastEvaluation(false); @@ -490,8 +491,11 @@ public class OgnlValueStack implements Serializable, ValueStack, ClearableValueS securityMemberAccess.useExcludeProperties(excludeProperties); } - @Inject + /** + * @deprecated since 6.4.0, no replacement. + */ + @Deprecated protected void setXWorkConverter(final XWorkConverter converter) { - this.converter = converter; + // no-op } }