Repository: struts Updated Branches: refs/heads/develop 6fbd1bef3 -> 5c4874c60
WW-4318 Uses ErrorMessageBuilder to proper log fail of setting expression Project: http://git-wip-us.apache.org/repos/asf/struts/repo Commit: http://git-wip-us.apache.org/repos/asf/struts/commit/5c4874c6 Tree: http://git-wip-us.apache.org/repos/asf/struts/tree/5c4874c6 Diff: http://git-wip-us.apache.org/repos/asf/struts/diff/5c4874c6 Branch: refs/heads/develop Commit: 5c4874c60bb5331258e4a415af8604afaf1242b5 Parents: 6fbd1be Author: Lukasz Lenart <lukaszlen...@apache.org> Authored: Mon Jul 28 21:01:45 2014 +0200 Committer: Lukasz Lenart <lukaszlen...@apache.org> Committed: Mon Jul 28 21:01:45 2014 +0200 ---------------------------------------------------------------------- .../main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/struts/blob/5c4874c6/xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java ---------------------------------------------------------------------- diff --git a/xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java b/xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java index acf54c4..90b1a54 100644 --- a/xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java +++ b/xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java @@ -208,7 +208,9 @@ public class OgnlValueStack implements Serializable, ValueStack, ClearableValueS boolean shouldLog = shouldLogMissingPropertyWarning(e); String msg = null; if (throwExceptionOnFailure || shouldLog) { - msg = "Error setting expression '" + expr + "' with value '" + value + "'"; + msg = ErrorMessageBuilder.create() + .errorSettingExpressionWithValue(expr, value) + .build(); } if (shouldLog) { LOG.warn(msg, e);
