Author: pbenedict
Date: Thu Jul 19 20:57:57 2007
New Revision: 557862
URL: http://svn.apache.org/viewvc?view=rev&rev=557862
Log:
STR-1870: Fail fast when definition is duplicated
Modified:
struts/struts1/trunk/tiles/src/main/java/org/apache/struts/tiles/TilesPlugin.java
Modified:
struts/struts1/trunk/tiles/src/main/java/org/apache/struts/tiles/TilesPlugin.java
URL:
http://svn.apache.org/viewvc/struts/struts1/trunk/tiles/src/main/java/org/apache/struts/tiles/TilesPlugin.java?view=diff&rev=557862&r1=557861&r2=557862
==============================================================================
---
struts/struts1/trunk/tiles/src/main/java/org/apache/struts/tiles/TilesPlugin.java
(original)
+++
struts/struts1/trunk/tiles/src/main/java/org/apache/struts/tiles/TilesPlugin.java
Thu Jul 19 20:57:57 2007
@@ -213,14 +213,12 @@
moduleConfig);
if (definitionFactory != null) {
- log.info(
+ throw new UnavailableException(
"Factory already exists for module '"
+ moduleConfig.getPrefix()
- + "'. The factory found is from module '"
- + definitionFactory.getConfig().getFactoryName()
- + "'. No new creation.");
-
- return;
+ + "' and cannot be redefined. " +
+ "The factory found is from module '"
+ + definitionFactory.getConfig().getFactoryName() + "'.");
}
// Create configurable factory
