svn commit: r510851 - in /struts/struts1/branches/STRUTS_1_3_BRANCH/core/src/main/java/org/apache/struts/chain/commands: AbstractCreateAction.java servlet/CreateAction.java

[pbenedict]

Author: pbenedict
Date: Thu Feb 22 23:05:18 2007
New Revision: 510851

URL: http://svn.apache.org/viewvc?view=rev&rev=510851
Log:
STR-3008: Make createAction() exclusive to CreateAction because it is 
sufficient for the base class to have getAction alone

Modified:
    
struts/struts1/branches/STRUTS_1_3_BRANCH/core/src/main/java/org/apache/struts/chain/commands/AbstractCreateAction.java
    
struts/struts1/branches/STRUTS_1_3_BRANCH/core/src/main/java/org/apache/struts/chain/commands/servlet/CreateAction.java

Modified: 
struts/struts1/branches/STRUTS_1_3_BRANCH/core/src/main/java/org/apache/struts/chain/commands/AbstractCreateAction.java
URL: 
http://svn.apache.org/viewvc/struts/struts1/branches/STRUTS_1_3_BRANCH/core/src/main/java/org/apache/struts/chain/commands/AbstractCreateAction.java?view=diff&rev=510851&r1=510850&r2=510851
==============================================================================
--- 
struts/struts1/branches/STRUTS_1_3_BRANCH/core/src/main/java/org/apache/struts/chain/commands/AbstractCreateAction.java
 (original)
+++ 
struts/struts1/branches/STRUTS_1_3_BRANCH/core/src/main/java/org/apache/struts/chain/commands/AbstractCreateAction.java
 Thu Feb 22 23:05:18 2007
@@ -117,19 +117,4 @@
     protected abstract Action getAction(ActionContext context, String type,
         ActionConfig actionConfig)
         throws Exception;
-    
-    /**
-     * <p>Invoked by <code>getAction</code> when the <code>Action</code> 
-     * actually has to be created. If the instance is already created and 
-     * cached, this method will not be called. </p>
-     * 
-     * @param context      The <code>Context</code> for this request
-     * @param type         Name of class to instantiate
-     * @return Instantiated Action class
-     * @throws Exception if there are any problems instantiating the Action
-     *                   class.
-     * @since Struts 1.3.7
-     */
-    protected abstract Action createAction(ActionContext context, String type)
-        throws Exception;
 }

Modified: 
struts/struts1/branches/STRUTS_1_3_BRANCH/core/src/main/java/org/apache/struts/chain/commands/servlet/CreateAction.java
URL: 
http://svn.apache.org/viewvc/struts/struts1/branches/STRUTS_1_3_BRANCH/core/src/main/java/org/apache/struts/chain/commands/servlet/CreateAction.java?view=diff&rev=510851&r1=510850&r2=510851
==============================================================================
--- 
struts/struts1/branches/STRUTS_1_3_BRANCH/core/src/main/java/org/apache/struts/chain/commands/servlet/CreateAction.java
 (original)
+++ 
struts/struts1/branches/STRUTS_1_3_BRANCH/core/src/main/java/org/apache/struts/chain/commands/servlet/CreateAction.java
 Thu Feb 22 23:05:18 2007
@@ -80,6 +80,19 @@
         return (action);
     }
 
+    
+    /**
+     * <p>Invoked by <code>getAction</code> when the <code>Action</code> 
+     * actually has to be created. If the instance is already created and 
+     * cached, this method will not be called. </p>
+     * 
+     * @param context      The <code>Context</code> for this request
+     * @param type         Name of class to instantiate
+     * @return Instantiated Action class
+     * @throws Exception if there are any problems instantiating the Action
+     *                   class.
+     * @since Struts 1.3.7
+     */
     protected Action createAction(ActionContext context, String type) throws 
Exception {
         log.info("Initialize action of type: " + type);
         return (Action) ClassUtils.getApplicationInstance(type);