Author: craigmcc
Date: Mon Jul 3 22:32:53 2006
New Revision: 418916
URL: http://svn.apache.org/viewvc?rev=418916&view=rev
Log:
Personalize the Checkstyle script a bit (Struts->Shale). No substantive
changes yet, although I am accumulating a list of stuff to talk about as
I go through the first passes of Checkstyle cleanups.
Modified:
struts/shale/trunk/maven/build/shale_checks.xml
Modified: struts/shale/trunk/maven/build/shale_checks.xml
URL:
http://svn.apache.org/viewvc/struts/shale/trunk/maven/build/shale_checks.xml?rev=418916&r1=418915&r2=418916&view=diff
==============================================================================
--- struts/shale/trunk/maven/build/shale_checks.xml (original)
+++ struts/shale/trunk/maven/build/shale_checks.xml Mon Jul 3 22:32:53 2006
@@ -1,7 +1,7 @@
<?xml version="1.0"?>
<!--
/*
- * Copyright 2001-2005 The Apache Software Foundation.
+ * Copyright 2006 The Apache Software Foundation.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -22,7 +22,7 @@
"http://www.puppycrawl.com/dtds/configuration_1_1.dtd";>
<!--
- Checkstyle configuration for Struts. Struts uses the Sun coding guidelines,
+ Checkstyle configuration for Shale. Shale uses the Sun coding guidelines,
so this file is almost the same as Maven's sun_checks.xml file. The only
changes from that file are:
@@ -30,7 +30,7 @@
the Subversion 'Id' keyword in file headers, which needs to be ignored
in the header check.
- - Disable the HiddenField module, since Struts has always used the
+ - Disable the HiddenField module, since Shale has always used the
"this.foo = foo" pattern, which is not recognised by this module.
- Disable the DesignForExtension module, since fixing those complaints
@@ -39,7 +39,7 @@
- Disable the FinalParameters module, since fixing those complaints
would result in backwards incompatible API changes.
- - Disable the InlineConditions modules, since Struts has always used
+ - Disable the InlineConditions modules, since Shale has always used
this construct.
- Increase LineLength max to 120 since Jalopy is set to format lines at
@@ -151,12 +151,12 @@
<!-- Checks for Size Violations. -->
<!-- See http://checkstyle.sf.net/config_sizes.html -->
<module name="FileLength"/>
- <!-- Begin Custom for Struts -->
+ <!-- Begin Custom for Shale -->
<module name="LineLength">
<property name="max" value="120"/>
<property name="ignorePattern" value="^ \* @version .*$"/>
</module>
- <!-- End Custom for Struts -->
+ <!-- End Custom for Shale -->
<module name="MethodLength"/>
<module name="ParameterNumber"/>
@@ -164,12 +164,12 @@
<!-- Checks for whitespace -->
<!-- See http://checkstyle.sf.net/config_whitespace.html -->
<module name="EmptyForIteratorPad"/>
- <!-- Struts Custom begins (omit ARRAY_INIT) -->
+ <!-- Shale Custom begins (omit ARRAY_INIT) -->
<module name="NoWhitespaceAfter">
<property name="tokens"
value="BNOT, DEC, DOT, INC, LNOT, UNARY_MINUS, UNARY_PLUS"/>
</module>
- <!-- Struts Custom ends -->
+ <!-- Shale Custom ends -->
<module name="NoWhitespaceBefore"/>
<module name="OperatorWrap"/>
<module name="ParenPad"/>
@@ -196,12 +196,12 @@
<!-- Checks for common coding problems -->
<!-- See http://checkstyle.sf.net/config_coding.html -->
- <!-- Disabled for Struts: module name="AvoidInlineConditionals"/ -->
+ <!-- Disabled for Shale: module name="AvoidInlineConditionals"/ -->
<module name="DoubleCheckedLocking"/>
<!-- MY FAVOURITE -->
<module name="EmptyStatement"/>
<module name="EqualsHashCode"/>
- <!-- Disabled for Struts: module name="HiddenField"/ -->
+ <!-- Disabled for Shale: module name="HiddenField"/ -->
<module name="IllegalInstantiation"/>
<module name="InnerAssignment"/>
<module name="MagicNumber"/>
@@ -212,7 +212,7 @@
<!-- Checks for class design -->
<!-- See http://checkstyle.sf.net/config_design.html -->
- <!-- Disabled for Struts: module name="DesignForExtension"/ -->
+ <!-- Disabled for Shale: module name="DesignForExtension"/ -->
<module name="FinalClass"/>
<module name="HideUtilityClassConstructor"/>
<module name="InterfaceIsType"/>
@@ -224,7 +224,7 @@
<!-- Miscellaneous other checks. -->
<!-- See http://checkstyle.sf.net/config_misc.html -->
<module name="ArrayTypeStyle"/>
- <!-- Disabled for Struts: module name="FinalParameters"/ -->
+ <!-- Disabled for Shale: module name="FinalParameters"/ -->
<module name="GenericIllegalRegexp">
<property name="format" value="\s+$"/>
<property name="message" value="Line has trailing spaces."/>
