This is an automated email from the ASF dual-hosted git repository.

cloud-fan pushed a commit to branch branch-4.2
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/branch-4.2 by this push:
     new 75580b2d3ad9 [SPARK-56395][SQL][FOLLOWUP] Fix missing comma in 
MimaExcludes on branch-4.2
75580b2d3ad9 is described below

commit 75580b2d3ad908dacf55cfaa9cb644d980ab1337
Author: Wenchen Fan <[email protected]>
AuthorDate: Thu May 14 16:58:58 2026 +0800

    [SPARK-56395][SQL][FOLLOWUP] Fix missing comma in MimaExcludes on branch-4.2
    
    ### What changes were proposed in this pull request?
    
    Add a missing trailing comma to the `DataStreamReader.name` MiMa exclude 
entry in `project/MimaExcludes.scala` on branch-4.2. The cherry-pick of 
SPARK-56395 (commit 2c356ac6c2d) added a new `Dataset.nearestByJoin` exclude 
entry to `v42excludes` but did not append the required comma to the preceding 
`DataStreamReader.name` entry.
    
    ### Why are the changes needed?
    
    Without the comma, SBT project loading fails on branch-4.2:
    
    ```
    [error] /home/runner/work/spark/spark/project/MimaExcludes.scala:62:19: ')' 
expected but '.' found.
    [error]     
ProblemFilters.exclude[ReversedMissingMethodProblem]("org.apache.spark.sql.Dataset.nearestByJoin")
    [error]                   ^
    [error] /home/runner/work/spark/spark/project/MimaExcludes.scala:63:3: ';' 
expected but ')' found.
    [error]   )
    [error]   ^
    [error] two errors found
    [error] (Compile / compileIncremental) Compilation failed
    ```
    
    This breaks all CI builds on branch-4.2. Reported by LuciferYang in 
https://github.com/apache/spark/pull/55682#discussion_r3239241097. This change 
is branch-4.2 only; master is unaffected because the `nearestByJoin` entry has 
not been merged to master yet.
    
    ### Does this PR introduce _any_ user-facing change?
    
    No.
    
    ### How was this patch tested?
    
    Existing CI. The fix restores compilability of the SBT project definition.
    
    ### Was this patch authored or co-authored using generative AI tooling?
    
    Generated-by: Claude Code (Opus 4.7)
    
    Closes #55873 from cloud-fan/cloud-fan/SPARK-56395-branch-4.2-fix.
    
    Authored-by: Wenchen Fan <[email protected]>
    Signed-off-by: Wenchen Fan <[email protected]>
---
 project/MimaExcludes.scala | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/project/MimaExcludes.scala b/project/MimaExcludes.scala
index ec9146459d8d..6bdd04517f06 100644
--- a/project/MimaExcludes.scala
+++ b/project/MimaExcludes.scala
@@ -57,7 +57,7 @@ object MimaExcludes {
     // [SPARK-56330][CORE] Add TaskInterruptListener to TaskContext for 
interrupt notifications
     
ProblemFilters.exclude[ReversedMissingMethodProblem]("org.apache.spark.TaskContext.addTaskInterruptListener"),
     // [SPARK-56700][SS] Make DataStreamReader.name public
-    
ProblemFilters.exclude[ReversedMissingMethodProblem]("org.apache.spark.sql.streaming.DataStreamReader.name")
+    
ProblemFilters.exclude[ReversedMissingMethodProblem]("org.apache.spark.sql.streaming.DataStreamReader.name"),
     // [SPARK-56395][SQL] Add NEAREST BY top-K ranking join
     
ProblemFilters.exclude[ReversedMissingMethodProblem]("org.apache.spark.sql.Dataset.nearestByJoin")
   )


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to