This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new bd46e21a2cb4 [SPARK-53991][SQL][FOLLOWUP] Remove wrong comments added
in PR #53463
bd46e21a2cb4 is described below
commit bd46e21a2cb4d30eb9a9028c84807403db190fc6
Author: Daniel Tenedorio <[email protected]>
AuthorDate: Tue Dec 16 08:57:06 2025 +0900
[SPARK-53991][SQL][FOLLOWUP] Remove wrong comments added in PR #53463
### What changes were proposed in this pull request?
This PR removes two wrong comment lines added in [PR
#53463](https://github.com/apache/spark/pull/53463).
### Why are the changes needed?
These two accidental comment lines don't apply to Apache Spark and will be
removed.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
N/A, comment changes only
### Was this patch authored or co-authored using generative AI tooling?
No
Closes #53477 from dtenedor/kll-get-quantile-rank-remove-comments.
Authored-by: Daniel Tenedorio <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
---
.../org/apache/spark/sql/catalyst/expressions/kllExpressions.scala | 2 --
1 file changed, 2 deletions(-)
diff --git
a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/kllExpressions.scala
b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/kllExpressions.scala
index 0556ef118e02..b446b2d0d443 100644
---
a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/kllExpressions.scala
+++
b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/kllExpressions.scala
@@ -469,7 +469,6 @@ abstract class KllSketchGetQuantileBase
protected def outputDataType: DataType
// The rank argument must be foldable (compile-time constant).
- // This enables Photon to efficiently handle array outputs with a known
constant size.
override def checkInputDataTypes(): TypeCheckResult = {
if (!right.foldable) {
TypeCheckResult.DataTypeMismatch(
@@ -635,7 +634,6 @@ abstract class KllSketchGetRankBase
protected def kllSketchGetRank(memory: Memory, quantile: Any): Double
// The quantile argument must be foldable (compile-time constant).
- // This enables Photon to efficiently handle array outputs with a known
constant size.
override def checkInputDataTypes(): TypeCheckResult = {
if (!right.foldable) {
TypeCheckResult.DataTypeMismatch(
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
