This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/spark-kubernetes-operator.git
The following commit(s) were added to refs/heads/main by this push:
new 4222d4a [MINOR] Remove unnecesary string splits in test code
4222d4a is described below
commit 4222d4abab07c547f9c4ad28bb6c71b68360eefa
Author: Dongjoon Hyun <[email protected]>
AuthorDate: Wed Sep 24 15:19:13 2025 -0700
[MINOR] Remove unnecesary string splits in test code
### What changes were proposed in this pull request?
This PR aims to remove unnenesary string splits in the test code.
### Why are the changes needed?
There are three instances which looks like mistakes.
```java
- "ConfigMap name" + " should include secondary resource prefix");
+ "ConfigMap name should include secondary resource prefix");
```
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Pass the CIs.
### Was this patch authored or co-authored using generative AI tooling?
No.
Closes #338 from dongjoon-hyun/minor_string.
Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
---
.../java/org/apache/spark/k8s/operator/spec/ApplicationSpecTest.java | 2 +-
.../java/org/apache/spark/k8s/operator/SparkAppDriverConfTest.java | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git
a/spark-operator-api/src/test/java/org/apache/spark/k8s/operator/spec/ApplicationSpecTest.java
b/spark-operator-api/src/test/java/org/apache/spark/k8s/operator/spec/ApplicationSpecTest.java
index 59e6544..2706ee5 100644
---
a/spark-operator-api/src/test/java/org/apache/spark/k8s/operator/spec/ApplicationSpecTest.java
+++
b/spark-operator-api/src/test/java/org/apache/spark/k8s/operator/spec/ApplicationSpecTest.java
@@ -58,7 +58,7 @@ class ApplicationSpecTest {
InputStream inputStream =
getClass()
.getClassLoader()
- .getResourceAsStream("spark-job-with-driver-service" +
"-ingress.json");
+ .getResourceAsStream("spark-job-with-driver-service-ingress.json");
ApplicationSpec spec = objectMapper.readValue(inputStream,
ApplicationSpec.class);
assertNotNull(spec.getDriverServiceIngressList());
assertEquals(1, spec.getDriverServiceIngressList().size());
diff --git
a/spark-submission-worker/src/test/java/org/apache/spark/k8s/operator/SparkAppDriverConfTest.java
b/spark-submission-worker/src/test/java/org/apache/spark/k8s/operator/SparkAppDriverConfTest.java
index d19cb05..2070aed 100644
---
a/spark-submission-worker/src/test/java/org/apache/spark/k8s/operator/SparkAppDriverConfTest.java
+++
b/spark-submission-worker/src/test/java/org/apache/spark/k8s/operator/SparkAppDriverConfTest.java
@@ -52,10 +52,10 @@ class SparkAppDriverConfTest {
+ "but different values are detected");
assertTrue(
sparkAppDriverConf.configMapNameDriver().contains(resourcePrefix),
- "ConfigMap name" + " should include secondary resource prefix");
+ "ConfigMap name should include secondary resource prefix");
assertTrue(
sparkAppDriverConf.driverServiceName().contains(resourcePrefix),
- "Driver service " + "name should include secondary resource prefix");
+ "Driver service name should include secondary resource prefix");
}
@Test
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
