This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new 5990db0a3c1a [SPARK-52652][BUILD] Replace `os-maven-plugin` with
`nisse`
5990db0a3c1a is described below
commit 5990db0a3c1aa9b7a0dfd6f2fddbb6152d5d83f5
Author: Cheng Pan <[email protected]>
AuthorDate: Wed Jul 2 13:56:12 2025 -0700
[SPARK-52652][BUILD] Replace `os-maven-plugin` with `nisse`
### What changes were proposed in this pull request?
[Nisse](https://github.com/maveniverse/nisse) provides drop-in-replacement
for discontinued [OS Detector
plugin](https://github.com/trustin/os-maven-plugin), the former works for both
Maven 3 and 4, but the latter does not work for upcoming Maven 4.
https://maven.apache.org/docs/4.0.0-rc-3/release-notes.html
> the useful, but unmaintained,
[os-maven-plugin](https://github.com/trustin/os-maven-plugin/) extension has
been replaced with at [nisse](https://github.com/maveniverse/nisse) extension.
### Why are the changes needed?
Prepare for Maven 4 support.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Pass GHA's Maven building.
### Was this patch authored or co-authored using generative AI tooling?
No.
Closes #51350 from pan3793/SPARK-52652.
Authored-by: Cheng Pan <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
---
.mvn/extensions.xml | 24 ++++++++++++++++++++++++
.mvn/maven.config | 1 +
sql/connect/common/pom.xml | 7 -------
3 files changed, 25 insertions(+), 7 deletions(-)
diff --git a/.mvn/extensions.xml b/.mvn/extensions.xml
new file mode 100644
index 000000000000..da2aee8827a5
--- /dev/null
+++ b/.mvn/extensions.xml
@@ -0,0 +1,24 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one or more
+ ~ contributor license agreements. See the NOTICE file distributed with
+ ~ this work for additional information regarding copyright ownership.
+ ~ The ASF licenses this file to You under the Apache License, Version 2.0
+ ~ (the "License"); you may not use this file except in compliance with
+ ~ the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ -->
+<extensions>
+ <extension>
+ <groupId>eu.maveniverse.maven.nisse</groupId>
+ <artifactId>extension</artifactId>
+ <version>0.4.6</version>
+ </extension>
+</extensions>
diff --git a/.mvn/maven.config b/.mvn/maven.config
new file mode 100644
index 000000000000..e61f1a94abde
--- /dev/null
+++ b/.mvn/maven.config
@@ -0,0 +1 @@
+-Dnisse.compat.osDetector
diff --git a/sql/connect/common/pom.xml b/sql/connect/common/pom.xml
index 18fb06ff3341..6ff47ec6d68c 100644
--- a/sql/connect/common/pom.xml
+++ b/sql/connect/common/pom.xml
@@ -105,13 +105,6 @@
</dependencies>
<build>
<!-- Protobuf compilation for Spark Connect -->
- <extensions>
- <extension>
- <groupId>kr.motd.maven</groupId>
- <artifactId>os-maven-plugin</artifactId>
- <version>1.6.2</version>
- </extension>
- </extensions>
<outputDirectory>target/scala-${scala.binary.version}/classes</outputDirectory>
<testOutputDirectory>target/scala-${scala.binary.version}/test-classes</testOutputDirectory>
<plugins>
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
