This is an automated email from the ASF dual-hosted git repository.
yangjie01 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new 1597d8174a5 [SPARK-43850][BUILD][GRAPHX] Remove the import for
`scala.language.higherKinds` and delete the corresponding suppression rule
1597d8174a5 is described below
commit 1597d8174a54b8657572f2e40897a20c985d2794
Author: yangjie01 <[email protected]>
AuthorDate: Wed Sep 27 12:26:46 2023 +0800
[SPARK-43850][BUILD][GRAPHX] Remove the import for
`scala.language.higherKinds` and delete the corresponding suppression rule
### What changes were proposed in this pull request?
`scala.language.higherKinds` is deprecated and no longer needs to be
imported explicitly in Scala 2.13, so this PR removes the imports for
scala.language.higherKinds and the corresponding compiler suppression rules.
### Why are the changes needed?
In SPARK-43849(https://github.com/apache/spark/pull/41356), I added
compiler suppression rules to allow `unused imports` checks to work with both
Scala 2.12 and Scala 2.13. As there is no longer a need to support Scala 2.12,
we can now clean them up.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Pass GitHub Actions
### Was this patch authored or co-authored using generative AI tooling?
No
Closes #43128 from LuciferYang/SPARK-43850.
Authored-by: yangjie01 <[email protected]>
Signed-off-by: yangjie01 <[email protected]>
---
.../scala/org/apache/spark/graphx/impl/VertexPartitionBase.scala | 1 -
.../scala/org/apache/spark/graphx/impl/VertexPartitionBaseOps.scala | 1 -
pom.xml | 6 ------
project/SparkBuild.scala | 4 ----
4 files changed, 12 deletions(-)
diff --git
a/graphx/src/main/scala/org/apache/spark/graphx/impl/VertexPartitionBase.scala
b/graphx/src/main/scala/org/apache/spark/graphx/impl/VertexPartitionBase.scala
index 8da46db98be..bbc4bca5016 100644
---
a/graphx/src/main/scala/org/apache/spark/graphx/impl/VertexPartitionBase.scala
+++
b/graphx/src/main/scala/org/apache/spark/graphx/impl/VertexPartitionBase.scala
@@ -17,7 +17,6 @@
package org.apache.spark.graphx.impl
-import scala.language.higherKinds
import scala.reflect.ClassTag
import org.apache.spark.graphx._
diff --git
a/graphx/src/main/scala/org/apache/spark/graphx/impl/VertexPartitionBaseOps.scala
b/graphx/src/main/scala/org/apache/spark/graphx/impl/VertexPartitionBaseOps.scala
index a8ed59b09bb..cf4c8ca2a9c 100644
---
a/graphx/src/main/scala/org/apache/spark/graphx/impl/VertexPartitionBaseOps.scala
+++
b/graphx/src/main/scala/org/apache/spark/graphx/impl/VertexPartitionBaseOps.scala
@@ -17,7 +17,6 @@
package org.apache.spark.graphx.impl
-import scala.language.higherKinds
import scala.language.implicitConversions
import scala.reflect.ClassTag
diff --git a/pom.xml b/pom.xml
index 1d0ab387900..6dc54a9bc94 100644
--- a/pom.xml
+++ b/pom.xml
@@ -2970,12 +2970,6 @@
<arg>-Wconf:cat=unchecked&msg=outer reference:s</arg>
<arg>-Wconf:cat=unchecked&msg=eliminated by erasure:s</arg>
<arg>-Wconf:msg=^(?=.*?a value of type)(?=.*?cannot also
be).+$:s</arg>
- <!--
- TODO(SPARK-43850): Remove the following suppression rules and
remove `import scala.language.higherKinds`
- from the corresponding files when Scala 2.12 is no longer
supported.
- -->
-
<arg>-Wconf:cat=unused-imports&src=org\/apache\/spark\/graphx\/impl\/VertexPartitionBase.scala:s</arg>
-
<arg>-Wconf:cat=unused-imports&src=org\/apache\/spark\/graphx\/impl\/VertexPartitionBaseOps.scala:s</arg>
<!--
SPARK-40497 Upgrade Scala to 2.13.11 and suppress `Implicit
definition should have explicit type`
-->
diff --git a/project/SparkBuild.scala b/project/SparkBuild.scala
index ad2b67c67c6..817f79a84a4 100644
--- a/project/SparkBuild.scala
+++ b/project/SparkBuild.scala
@@ -258,10 +258,6 @@ object SparkBuild extends PomBuild {
"-Wconf:cat=unchecked&msg=outer reference:s",
"-Wconf:cat=unchecked&msg=eliminated by erasure:s",
"-Wconf:msg=^(?=.*?a value of type)(?=.*?cannot also be).+$:s",
- // TODO(SPARK-43850): Remove the following suppression rules and
remove `import scala.language.higherKinds`
- // from the corresponding files when Scala 2.12 is no longer supported.
-
"-Wconf:cat=unused-imports&src=org\\/apache\\/spark\\/graphx\\/impl\\/VertexPartitionBase.scala:s",
-
"-Wconf:cat=unused-imports&src=org\\/apache\\/spark\\/graphx\\/impl\\/VertexPartitionBaseOps.scala:s",
// SPARK-40497 Upgrade Scala to 2.13.11 and suppress `Implicit
definition should have explicit type`
"-Wconf:msg=Implicit definition should have explicit type:s"
)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
