This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new 5df4e165460 [SPARK-45021][BUILD] Remove `antlr4-maven-plugin`
configuration from `sql/catalyst/pom.xml`
5df4e165460 is described below
commit 5df4e16546095a8931e7e87998470603e01c6695
Author: yangjie01 <[email protected]>
AuthorDate: Wed Aug 30 08:40:48 2023 -0700
[SPARK-45021][BUILD] Remove `antlr4-maven-plugin` configuration from
`sql/catalyst/pom.xml`
### What changes were proposed in this pull request?
SPARK-44475(https://github.com/apache/spark/pull/41928) has already moved
the `antlr4-maven-plugin` relevant configuration to `sql/api/pom.xml`, so the
configuration in the `catalyst` module is unused now, so this pr remove it from
`sql/catalyst/pom.xml`
### Why are the changes needed?
Clean up unused Maven `antlr4-maven-plugin` from catalyst module.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
- Pass GitHub Actions
- Manual verification
```
build/mvn clean install -DskipTests -pl sql/catalyst -am
```
Before
We can see
```
[INFO]
[INFO] --- antlr4-maven-plugin:4.9.3:antlr4 (default) spark-catalyst_2.12
---
[INFO] No ANTLR 4 grammars to compile in
/Users/yangjie01/SourceCode/git/spark-mine-12/sql/catalyst/src/main/antlr4
[INFO]
```
After
no relevant messages.
### Was this patch authored or co-authored using generative AI tooling?
No
Closes #42739 from LuciferYang/remove-antlr4-catalyst.
Authored-by: yangjie01 <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
---
sql/catalyst/pom.xml | 16 ----------------
1 file changed, 16 deletions(-)
diff --git a/sql/catalyst/pom.xml b/sql/catalyst/pom.xml
index fa456487de5..7feeb158143 100644
--- a/sql/catalyst/pom.xml
+++ b/sql/catalyst/pom.xml
@@ -154,22 +154,6 @@
<argLine>-ea -Xmx4g -Xss4m
-XX:ReservedCodeCacheSize=${CodeCacheSize} ${extraJavaTestArgs}
-Dio.netty.tryReflectionSetAccessible=true</argLine>
</configuration>
</plugin>
- <plugin>
- <groupId>org.antlr</groupId>
- <artifactId>antlr4-maven-plugin</artifactId>
- <executions>
- <execution>
- <goals>
- <goal>antlr4</goal>
- </goals>
- </execution>
- </executions>
- <configuration>
- <visitor>true</visitor>
- <sourceDirectory>../catalyst/src/main/antlr4</sourceDirectory>
- <treatWarningsAsErrors>true</treatWarningsAsErrors>
- </configuration>
- </plugin>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>build-helper-maven-plugin</artifactId>
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
