[spark] branch master updated: [MINOR][SQL] Rename shouldBroadcast to isDynamicPruning in InSubqueryExec

[wenchen]

This is an automated email from the ASF dual-hosted git repository.

wenchen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/master by this push:
     new 7070b3672d8 [MINOR][SQL] Rename shouldBroadcast to isDynamicPruning in 
InSubqueryExec
7070b3672d8 is described below

commit 7070b3672d8426834ff936fff4543b10093042fc
Author: Ziqi Liu <ziqi....@databricks.com>
AuthorDate: Sat Aug 12 21:40:22 2023 +0800

    [MINOR][SQL] Rename shouldBroadcast to isDynamicPruning in InSubqueryExec
    
    ### What changes were proposed in this pull request?
    
    Rename `shouldBroadcast` param to `isDynamicPruning`.
    
    ### Why are the changes needed?
    
    Explicitly indicating the behavior mode of DPP
    
    ### Does this PR introduce _any_ user-facing change?
    NO
    
    ### How was this patch tested?
    
    Closes #42286 from liuzqt/insubqueryexec-rename.
    
    Authored-by: Ziqi Liu <ziqi....@databricks.com>
    Signed-off-by: Wenchen Fan <wenc...@databricks.com>
---
 .../spark/sql/execution/adaptive/PlanAdaptiveSubqueries.scala       | 2 +-
 .../src/main/scala/org/apache/spark/sql/execution/subquery.scala    | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git 
a/sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/PlanAdaptiveSubqueries.scala
 
b/sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/PlanAdaptiveSubqueries.scala
index 5b4a7e50db7..7816fbd52c0 100644
--- 
a/sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/PlanAdaptiveSubqueries.scala
+++ 
b/sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/PlanAdaptiveSubqueries.scala
@@ -45,7 +45,7 @@ case class PlanAdaptiveSubqueries(
           )
         }
         val subquery = SubqueryExec(s"subquery#${exprId.id}", 
subqueryMap(exprId.id))
-        InSubqueryExec(expr, subquery, exprId, shouldBroadcast = true)
+        InSubqueryExec(expr, subquery, exprId, isDynamicPruning = false)
       case expressions.DynamicPruningSubquery(value, buildPlan,
           buildKeys, broadcastKeyIndex, onlyInBroadcast, exprId, _) =>
         val name = s"dynamicpruning#${exprId.id}"
diff --git 
a/sql/core/src/main/scala/org/apache/spark/sql/execution/subquery.scala 
b/sql/core/src/main/scala/org/apache/spark/sql/execution/subquery.scala
index 2a28f6848aa..41230c7792c 100644
--- a/sql/core/src/main/scala/org/apache/spark/sql/execution/subquery.scala
+++ b/sql/core/src/main/scala/org/apache/spark/sql/execution/subquery.scala
@@ -117,7 +117,7 @@ case class InSubqueryExec(
     child: Expression,
     plan: BaseSubqueryExec,
     exprId: ExprId,
-    shouldBroadcast: Boolean = false,
+    isDynamicPruning: Boolean = true,
     private var resultBroadcast: Broadcast[Array[Any]] = null,
     @transient private var result: Array[Any] = null)
   extends ExecSubqueryExpression with UnaryLike[Expression] with Predicate {
@@ -136,7 +136,7 @@ case class InSubqueryExec(
     } else {
       rows.map(_.get(0, child.dataType))
     }
-    if (shouldBroadcast) {
+    if (!isDynamicPruning) {
       resultBroadcast = plan.session.sparkContext.broadcast(result)
     }
   }
@@ -198,7 +198,7 @@ case class PlanSubqueries(sparkSession: SparkSession) 
extends Rule[SparkPlan] {
         }
         val executedPlan = QueryExecution.prepareExecutedPlan(sparkSession, 
query)
         InSubqueryExec(expr, SubqueryExec(s"subquery#${exprId.id}", 
executedPlan),
-          exprId, shouldBroadcast = true)
+          exprId, isDynamicPruning = false)
     }
   }
 }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org