This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch branch-2.4
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/branch-2.4 by this push:
new 816ffd7 [SPARK-33136][SQL][2.4] Fix mistakenly swapped parameter in
V2WriteCommand.outputResolved
816ffd7 is described below
commit 816ffd7f10eaaaba334ca90554cda75beca8083f
Author: Jungtaek Lim (HeartSaVioR) <[email protected]>
AuthorDate: Wed Oct 14 20:09:37 2020 -0700
[SPARK-33136][SQL][2.4] Fix mistakenly swapped parameter in
V2WriteCommand.outputResolved
### What changes were proposed in this pull request?
This PR proposes to fix a bug on calling
`DataType.equalsIgnoreCompatibleNullability` with mistakenly swapped parameters
in `AppendData.outputResolved`. The order of parameters for
`DataType.equalsIgnoreCompatibleNullability` are `from` and `to`, which says
that the right order of matching variables are `inAttr` and `outAttr`.
### Why are the changes needed?
Although the problematic part is a dead code, once we know there's a bug,
preferably we'd like to fix that.
### Does this PR introduce _any_ user-facing change?
No, as this fixes the dead code.
### How was this patch tested?
This patch fixes the dead code, which is not easy to craft a test. (The
test in original commit is no longer valid here.)
Closes #30043 from HeartSaVioR/SPARK-33136-branch-2.4.
Authored-by: Jungtaek Lim (HeartSaVioR) <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
---
.../apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
index 1c25586..a0086c1 100644
---
a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
+++
b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
@@ -378,7 +378,7 @@ case class AppendData(
case (inAttr, outAttr) =>
// names and types must match, nullability must be compatible
inAttr.name == outAttr.name &&
- DataType.equalsIgnoreCompatibleNullability(outAttr.dataType,
inAttr.dataType) &&
+ DataType.equalsIgnoreCompatibleNullability(inAttr.dataType,
outAttr.dataType) &&
(outAttr.nullable || !inAttr.nullable)
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
