This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new 7c85968 [SPARK-29218][WEBUI] Increase `Show Additional Metrics`
checkbox width in StagePage
7c85968 is described below
commit 7c8596823a7dff5c05e5f61ff19e4b5179d38815
Author: Kousuke Saruta <saru...@oss.nttdata.com>
AuthorDate: Mon Sep 23 23:57:08 2019 -0700
[SPARK-29218][WEBUI] Increase `Show Additional Metrics` checkbox width in
StagePage
### What changes were proposed in this pull request?
Modified widths of some checkboxes in StagePage.
### Why are the changes needed?
When we increase the font size of the browsers or the default font size is
big, the labels of checkbox of `Show Additional Metrics` in `StagePage` are
wrapped like as follows.
### Does this PR introduce any user-facing change?
Yes.
### How was this patch tested?
Run the following and visit the `Stage Detail` page. Then, increase the
font size.
```
$ bin/spark-shell
...
scala> spark.range(100000).groupBy("id").count.collect
```
Closes #25905 from sarutak/adjust-checkbox-width.
Authored-by: Kousuke Saruta <saru...@oss.nttdata.com>
Signed-off-by: Dongjoon Hyun <dh...@apple.com>
---
.../resources/org/apache/spark/ui/static/stagepage.js | 2 +-
.../resources/org/apache/spark/ui/static/webui.css | 18 +++++++++++-------
2 files changed, 12 insertions(+), 8 deletions(-)
diff --git a/core/src/main/resources/org/apache/spark/ui/static/stagepage.js
b/core/src/main/resources/org/apache/spark/ui/static/stagepage.js
index 3ef1a76..b28c981 100644
--- a/core/src/main/resources/org/apache/spark/ui/static/stagepage.js
+++ b/core/src/main/resources/org/apache/spark/ui/static/stagepage.js
@@ -286,7 +286,7 @@ $(document).ready(function () {
" Show Additional Metrics" +
"</a></div>" +
"<div class='container-fluid container-fluid-div' id='toggle-metrics'
hidden>" +
- "<div><input type='checkbox' class='toggle-vis' id='box-0'
data-column='0'> Select All</div>" +
+ "<div id='select_all' class='select-all-checkbox-div'><input
type='checkbox' class='toggle-vis' id='box-0' data-column='0'> Select
All</div>" +
"<div id='scheduler_delay' class='scheduler-delay-checkbox-div'><input
type='checkbox' class='toggle-vis' id='box-11' data-column='11'> Scheduler
Delay</div>" +
"<div id='task_deserialization_time'
class='task-deserialization-time-checkbox-div'><input type='checkbox'
class='toggle-vis' id='box-12' data-column='12'> Task Deserialization
Time</div>" +
"<div id='shuffle_read_blocked_time'
class='shuffle-read-blocked-time-checkbox-div'><input type='checkbox'
class='toggle-vis' id='box-13' data-column='13'> Shuffle Read Blocked
Time</div>" +
diff --git a/core/src/main/resources/org/apache/spark/ui/static/webui.css
b/core/src/main/resources/org/apache/spark/ui/static/webui.css
index 3e28816..2b2e9c7 100644
--- a/core/src/main/resources/org/apache/spark/ui/static/webui.css
+++ b/core/src/main/resources/org/apache/spark/ui/static/webui.css
@@ -263,32 +263,36 @@ a.expandbutton {
width: 200px;
}
+.select-all-div-checkbox-div {
+ width: 90px;
+}
+
.scheduler-delay-checkbox-div {
- width: 120px;
+ width: 130px;
}
.task-deserialization-time-checkbox-div {
- width: 175px;
+ width: 190px;
}
.shuffle-read-blocked-time-checkbox-div {
- width: 187px;
+ width: 200px;
}
.shuffle-remote-reads-checkbox-div {
- width: 157px;
+ width: 170px;
}
.result-serialization-time-checkbox-div {
- width: 171px;
+ width: 185px;
}
.getting-result-time-checkbox-div {
- width: 141px;
+ width: 155px;
}
.peak-execution-memory-checkbox-div {
- width: 170px;
+ width: 180px;
}
#active-tasks-table th {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org
