This is an automated email from the ASF dual-hosted git repository.
vanzin pushed a commit to branch branch-2.3
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/branch-2.3 by this push:
new 3ece965 [MINOR][BUILD] Update all checkstyle dtd to use
"https://checkstyle.org";
3ece965 is described below
commit 3ece965c09c5d805a530fd33896ec0bb804eef8c
Author: Jungtaek Lim (HeartSaVioR) <[email protected]>
AuthorDate: Mon Feb 25 11:25:53 2019 -0800
[MINOR][BUILD] Update all checkstyle dtd to use "https://checkstyle.org";
## What changes were proposed in this pull request?
Below build failed with Java checkstyle test, but instead of violation it
shows FileNotFound on dtd file.
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/102751/
Looks like the link of dtd file is dead
`http://www.puppycrawl.com/dtds/configuration_1_3.dtd`.
This patch updates the dtd link to "https://checkstyle.org/dtds/"; given
checkstyle repository also updated the URL path.
https://github.com/checkstyle/checkstyle/issues/5601
## How was this patch tested?
Checked the new links.
Closes #23887 from HeartSaVioR/java-checkstyle-dtd-change-url.
Authored-by: Jungtaek Lim (HeartSaVioR) <[email protected]>
Signed-off-by: Marcelo Vanzin <[email protected]>
(cherry picked from commit c5de804093540509929f6de211dbbe644b33e6db)
Signed-off-by: Marcelo Vanzin <[email protected]>
---
dev/checkstyle-suppressions.xml | 2 +-
dev/checkstyle.xml | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/dev/checkstyle-suppressions.xml b/dev/checkstyle-suppressions.xml
index bbda824..945686d 100644
--- a/dev/checkstyle-suppressions.xml
+++ b/dev/checkstyle-suppressions.xml
@@ -17,7 +17,7 @@
<!DOCTYPE suppressions PUBLIC
"-//Puppy Crawl//DTD Suppressions 1.1//EN"
-"http://www.puppycrawl.com/dtds/suppressions_1_1.dtd";>
+"https://checkstyle.org/dtds/suppressions_1_1.dtd";>
<!--
diff --git a/dev/checkstyle.xml b/dev/checkstyle.xml
index 53c2848..7949568 100644
--- a/dev/checkstyle.xml
+++ b/dev/checkstyle.xml
@@ -17,7 +17,7 @@
<!DOCTYPE module PUBLIC
"-//Puppy Crawl//DTD Check Configuration 1.3//EN"
- "http://www.puppycrawl.com/dtds/configuration_1_3.dtd";>
+ "https://checkstyle.org/dtds/configuration_1_3.dtd";>
<!--
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
