This is an automated email from the ASF dual-hosted git repository.
wenchen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new 311f32f [SPARK-26571][SQL] Update Hive Serde mapping with canonical
name of Parquet and Orc FileFormat
311f32f is described below
commit 311f32f37fbeaebe9dfa0b8dc2a111ee99b583b7
Author: Gengliang Wang <gengliang.w...@databricks.com>
AuthorDate: Wed Jan 9 10:18:33 2019 +0800
[SPARK-26571][SQL] Update Hive Serde mapping with canonical name of Parquet
and Orc FileFormat
## What changes were proposed in this pull request?
Currently Spark table maintains Hive catalog storage format, so that Hive
client can read it. In `HiveSerDe.scala`, Spark uses a mapping from its data
source to HiveSerde. The mapping is old, we need to update with latest
canonical name of Parquet and Orc FileFormat.
Otherwise the following queries will result in wrong Serde value in Hive
table(default value `org.apache.hadoop.mapred.SequenceFileInputFormat`), and
Hive client will fail to read the output table:
```
df.write.format("org.apache.spark.sql.execution.datasources.parquet.ParquetFileFormat").saveAsTable(..)
```
```
df.write.format("org.apache.spark.sql.execution.datasources.orc.OrcFileFormat").saveAsTable(..)
```
This minor PR is to fix the mapping.
## How was this patch tested?
Unit test.
Closes #23491 from gengliangwang/fixHiveSerdeMap.
Authored-by: Gengliang Wang <gengliang.w...@databricks.com>
Signed-off-by: Wenchen Fan <wenc...@databricks.com>
---
.../org/apache/spark/sql/internal/HiveSerDe.scala | 2 ++
.../spark/sql/hive/HiveMetastoreCatalogSuite.scala | 18 ++++++++++++++
.../spark/sql/hive/orc/HiveOrcSourceSuite.scala | 29 ----------------------
3 files changed, 20 insertions(+), 29 deletions(-)
diff --git
a/sql/core/src/main/scala/org/apache/spark/sql/internal/HiveSerDe.scala
b/sql/core/src/main/scala/org/apache/spark/sql/internal/HiveSerDe.scala
index eca612f..bd25a64 100644
--- a/sql/core/src/main/scala/org/apache/spark/sql/internal/HiveSerDe.scala
+++ b/sql/core/src/main/scala/org/apache/spark/sql/internal/HiveSerDe.scala
@@ -74,8 +74,10 @@ object HiveSerDe {
def sourceToSerDe(source: String): Option[HiveSerDe] = {
val key = source.toLowerCase(Locale.ROOT) match {
case s if s.startsWith("org.apache.spark.sql.parquet") => "parquet"
+ case s if
s.startsWith("org.apache.spark.sql.execution.datasources.parquet") => "parquet"
case s if s.startsWith("org.apache.spark.sql.orc") => "orc"
case s if s.startsWith("org.apache.spark.sql.hive.orc") => "orc"
+ case s if s.startsWith("org.apache.spark.sql.execution.datasources.orc")
=> "orc"
case s if s.equals("orcfile") => "orc"
case s if s.equals("parquetfile") => "parquet"
case s if s.equals("avrofile") => "avro"
diff --git
a/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveMetastoreCatalogSuite.scala
b/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveMetastoreCatalogSuite.scala
index 688b619..5c9261c 100644
---
a/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveMetastoreCatalogSuite.scala
+++
b/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveMetastoreCatalogSuite.scala
@@ -159,10 +159,28 @@ class DataSourceWithHiveMetastoreCatalogSuite
"org.apache.hadoop.hive.ql.io.parquet.serde.ParquetHiveSerDe"
)),
+ "org.apache.spark.sql.execution.datasources.parquet.ParquetFileFormat" ->
((
+ "org.apache.hadoop.hive.ql.io.parquet.MapredParquetInputFormat",
+ "org.apache.hadoop.hive.ql.io.parquet.MapredParquetOutputFormat",
+ "org.apache.hadoop.hive.ql.io.parquet.serde.ParquetHiveSerDe"
+ )),
+
"orc" -> ((
"org.apache.hadoop.hive.ql.io.orc.OrcInputFormat",
"org.apache.hadoop.hive.ql.io.orc.OrcOutputFormat",
"org.apache.hadoop.hive.ql.io.orc.OrcSerde"
+ )),
+
+ "org.apache.spark.sql.hive.orc" -> ((
+ "org.apache.hadoop.hive.ql.io.orc.OrcInputFormat",
+ "org.apache.hadoop.hive.ql.io.orc.OrcOutputFormat",
+ "org.apache.hadoop.hive.ql.io.orc.OrcSerde"
+ )),
+
+ "org.apache.spark.sql.execution.datasources.orc.OrcFileFormat" -> ((
+ "org.apache.hadoop.hive.ql.io.orc.OrcInputFormat",
+ "org.apache.hadoop.hive.ql.io.orc.OrcOutputFormat",
+ "org.apache.hadoop.hive.ql.io.orc.OrcSerde"
))
).foreach { case (provider, (inputFormat, outputFormat, serde)) =>
test(s"Persist non-partitioned $provider relation into metastore as
managed table") {
diff --git
a/sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/HiveOrcSourceSuite.scala
b/sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/HiveOrcSourceSuite.scala
index 7fefaf5..c46512b 100644
---
a/sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/HiveOrcSourceSuite.scala
+++
b/sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/HiveOrcSourceSuite.scala
@@ -21,11 +21,9 @@ import java.io.File
import org.apache.spark.sql.{AnalysisException, Row}
import org.apache.spark.sql.TestingUDT.{IntervalData, IntervalUDT}
-import org.apache.spark.sql.catalyst.TableIdentifier
import org.apache.spark.sql.execution.datasources.orc.OrcSuite
import org.apache.spark.sql.hive.HiveUtils
import org.apache.spark.sql.hive.test.TestHiveSingleton
-import org.apache.spark.sql.internal.HiveSerDe
import org.apache.spark.sql.types._
import org.apache.spark.util.Utils
@@ -67,33 +65,6 @@ class HiveOrcSourceSuite extends OrcSuite with
TestHiveSingleton {
""".stripMargin)
}
- test("SPARK-22972: hive orc source") {
- val tableName = "normal_orc_as_source_hive"
- withTable(tableName) {
- sql(
- s"""
- |CREATE TABLE $tableName
- |USING org.apache.spark.sql.hive.orc
- |OPTIONS (
- | PATH '${new File(orcTableAsDir.getAbsolutePath).toURI}'
- |)
- """.stripMargin)
-
- val tableMetadata = spark.sessionState.catalog.getTableMetadata(
- TableIdentifier(tableName))
- assert(tableMetadata.storage.inputFormat ==
- Option("org.apache.hadoop.hive.ql.io.orc.OrcInputFormat"))
- assert(tableMetadata.storage.outputFormat ==
- Option("org.apache.hadoop.hive.ql.io.orc.OrcOutputFormat"))
- assert(tableMetadata.storage.serde ==
- Option("org.apache.hadoop.hive.ql.io.orc.OrcSerde"))
- assert(HiveSerDe.sourceToSerDe("org.apache.spark.sql.hive.orc")
- .equals(HiveSerDe.sourceToSerDe("orc")))
- assert(HiveSerDe.sourceToSerDe("org.apache.spark.sql.orc")
- .equals(HiveSerDe.sourceToSerDe("orc")))
- }
- }
-
test("SPARK-19459/SPARK-18220: read char/varchar column written by Hive") {
val location = Utils.createTempDir()
val uri = location.toURI
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org
