This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new 61133cb [SPARK-26536][BUILD][FOLLOWUP][TEST-MAVEN] Make
StreamingReadSupport public for maven testing
61133cb is described below
commit 61133cb8a69e7814c3450e84ce9cc9226d7e8ad8
Author: Dongjoon Hyun <dongj...@apache.org>
AuthorDate: Sun Jan 6 21:00:10 2019 -0800
[SPARK-26536][BUILD][FOLLOWUP][TEST-MAVEN] Make StreamingReadSupport public
for maven testing
## What changes were proposed in this pull request?
`StreamingReadSupport` is designed to be a `package` interface. Mockito
seems to complain during `Maven` testing. This doesn't fail in `sbt` and
IntelliJ. For mock-testing purpose, this PR makes it `public` interface and
adds explicit comments like `public interface ReadSupport`
```scala
EpochCoordinatorSuite:
*** RUN ABORTED ***
java.lang.IllegalAccessError: tried to
access class
org.apache.spark.sql.sources.v2.reader.streaming.StreamingReadSupport
from class
org.apache.spark.sql.sources.v2.reader.streaming.ContinuousReadSupport$MockitoMock$58628338
at
org.apache.spark.sql.sources.v2.reader.streaming.ContinuousReadSupport$MockitoMock$58628338.<clinit>(Unknown
Source)
at
sun.reflect.GeneratedSerializationConstructorAccessor632.newInstance(Unknown
Source)
at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
at
org.objenesis.instantiator.sun.SunReflectionFactoryInstantiator.newInstance(SunReflectionFactoryInstantiator.java:48)
at org.objenesis.ObjenesisBase.newInstance(ObjenesisBase.java:73)
at
org.mockito.internal.creation.instance.ObjenesisInstantiator.newInstance(ObjenesisInstantiator.java:19)
at
org.mockito.internal.creation.bytebuddy.SubclassByteBuddyMockMaker.createMock(SubclassByteBuddyMockMaker.java:47)
at
org.mockito.internal.creation.bytebuddy.ByteBuddyMockMaker.createMock(ByteBuddyMockMaker.java:25)
at org.mockito.internal.util.MockUtil.createMock(MockUtil.java:35)
at org.mockito.internal.MockitoCore.mock(MockitoCore.java:69)
```
## How was this patch tested?
Pass the Jenkins with Maven build
Closes #23463 from dongjoon-hyun/SPARK-26536-2.
Authored-by: Dongjoon Hyun <dongj...@apache.org>
Signed-off-by: Dongjoon Hyun <dongj...@apache.org>
---
.../sql/sources/v2/reader/streaming/StreamingReadSupport.java | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git
a/sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/streaming/StreamingReadSupport.java
b/sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/streaming/StreamingReadSupport.java
index 84872d1..bd39fc8 100644
---
a/sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/streaming/StreamingReadSupport.java
+++
b/sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/streaming/StreamingReadSupport.java
@@ -17,14 +17,17 @@
package org.apache.spark.sql.sources.v2.reader.streaming;
+import com.google.common.annotations.VisibleForTesting;
+
import org.apache.spark.sql.sources.v2.reader.ReadSupport;
/**
- * A base interface for streaming read support. This is package private and is
invisible to data
- * sources. Data sources should implement concrete streaming read support
interfaces:
- * {@link MicroBatchReadSupport} or {@link ContinuousReadSupport}.
+ * A base interface for streaming read support. Data sources should implement
concrete streaming
+ * read support interfaces: {@link MicroBatchReadSupport} or {@link
ContinuousReadSupport}.
+ * This is exposed for a testing purpose.
*/
-interface StreamingReadSupport extends ReadSupport {
+@VisibleForTesting
+public interface StreamingReadSupport extends ReadSupport {
/**
* Returns the initial offset for a streaming query to start reading from.
Note that the
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org
