This is an automated email from the ASF dual-hosted git repository.
srowen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new d25e443 [MINOR][SQL] Some errors in the notes.
d25e443 is described below
commit d25e443eec6efc9172eade6ac11be7b3ff04759d
Author: CarolinPeng <[email protected]>
AuthorDate: Fri Dec 14 14:23:21 2018 -0600
[MINOR][SQL] Some errors in the notes.
## What changes were proposed in this pull request?
When using ordinals to access linked list, the time cost is O(n).
## How was this patch tested?
Existing tests.
Closes #23280 from CarolinePeng/update_Two.
Authored-by: CarolinPeng <[email protected]>
Signed-off-by: Sean Owen <[email protected]>
---
.../main/scala/org/apache/spark/sql/catalyst/expressions/package.scala | 2 +-
.../scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git
a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/package.scala
b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/package.scala
index 0083ee6..bf18e8b 100644
---
a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/package.scala
+++
b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/package.scala
@@ -101,7 +101,7 @@ package object expressions {
StructType(attrs.map(a => StructField(a.name, a.dataType, a.nullable,
a.metadata)))
}
- // It's possible that `attrs` is a linked list, which can lead to bad
O(n^2) loops when
+ // It's possible that `attrs` is a linked list, which can lead to bad O(n)
loops when
// accessing attributes by their ordinals. To avoid this performance
penalty, convert the input
// to an array.
@transient private lazy val attrsArray = attrs.toArray
diff --git
a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
index a520eba..3ad2ee6 100644
---
a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
+++
b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
@@ -93,7 +93,7 @@ abstract class LogicalPlan
/**
* Optionally resolves the given strings to a [[NamedExpression]] using the
input from all child
* nodes of this LogicalPlan. The attribute is expressed as
- * as string in the following form:
`[scope].AttributeName.[nested].[fields]...`.
+ * string in the following form:
`[scope].AttributeName.[nested].[fields]...`.
*/
def resolveChildren(
nameParts: Seq[String],
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
