Repository: spark Updated Branches: refs/heads/master d7f3058e1 -> 53ab8fb34
[SPARK-18742][CORE] Clarify that user-defined BroadcastFactory is not supported ## What changes were proposed in this pull request? After SPARK-12588 Remove HTTPBroadcast [1], the one and only implementation of BroadcastFactory is TorrentBroadcastFactory and the spark.broadcast.factory conf has removed. however the scaladoc says [2]: /** * An interface for all the broadcast implementations in Spark (to allow * multiple broadcast implementations). SparkContext uses a user-specified * BroadcastFactory implementation to instantiate a particular broadcast for the * entire Spark job. */ so we should modify the comment that SparkContext will not use a user-specified BroadcastFactory implementation [1] https://issues.apache.org/jira/browse/SPARK-12588 [2] https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/broadcast/BroadcastFactory.scala#L25-L30 ## How was this patch tested? unit test added Author: root <root@iZbp1gsnrlfzjxh82cz80vZ.(none)> Author: windpiger <[email protected]> Closes #16173 from windpiger/addBroadFactoryConf. Project: http://git-wip-us.apache.org/repos/asf/spark/repo Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/53ab8fb3 Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/53ab8fb3 Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/53ab8fb3 Branch: refs/heads/master Commit: 53ab8fb34682203d2138567c0a7deff34e0da9c5 Parents: d7f3058 Author: root <root@iZbp1gsnrlfzjxh82cz80vZ.(none)> Authored: Fri Dec 16 10:16:57 2016 +0000 Committer: Sean Owen <[email protected]> Committed: Fri Dec 16 10:16:57 2016 +0000 ---------------------------------------------------------------------- .../scala/org/apache/spark/broadcast/BroadcastFactory.scala | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/spark/blob/53ab8fb3/core/src/main/scala/org/apache/spark/broadcast/BroadcastFactory.scala ---------------------------------------------------------------------- diff --git a/core/src/main/scala/org/apache/spark/broadcast/BroadcastFactory.scala b/core/src/main/scala/org/apache/spark/broadcast/BroadcastFactory.scala index fd7b4fc..ece4ae6 100644 --- a/core/src/main/scala/org/apache/spark/broadcast/BroadcastFactory.scala +++ b/core/src/main/scala/org/apache/spark/broadcast/BroadcastFactory.scala @@ -24,9 +24,8 @@ import org.apache.spark.SparkConf /** * An interface for all the broadcast implementations in Spark (to allow - * multiple broadcast implementations). SparkContext uses a user-specified - * BroadcastFactory implementation to instantiate a particular broadcast for the - * entire Spark job. + * multiple broadcast implementations). SparkContext uses a BroadcastFactory + * implementation to instantiate a particular broadcast for the entire Spark job. */ private[spark] trait BroadcastFactory { --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
