Repository: spark Updated Branches: refs/heads/master cc95f1ed5 -> a21a3bbe6
[SPARK-15087][MINOR][DOC] Follow Up: Fix the Comments ## What changes were proposed in this pull request? Remove the Comment, since it not longer applies. see the discussion here(https://github.com/apache/spark/pull/12865#discussion-diff-61946906) Author: Sandeep Singh <[email protected]> Closes #12953 from techaddict/SPARK-15087-FOLLOW-UP. Project: http://git-wip-us.apache.org/repos/asf/spark/repo Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/a21a3bbe Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/a21a3bbe Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/a21a3bbe Branch: refs/heads/master Commit: a21a3bbe6931e162c53a61daff1ef428fb802b8a Parents: cc95f1e Author: Sandeep Singh <[email protected]> Authored: Sat May 7 11:10:14 2016 +0800 Committer: Wenchen Fan <[email protected]> Committed: Sat May 7 11:10:14 2016 +0800 ---------------------------------------------------------------------- .../scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala | 5 ----- 1 file changed, 5 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/spark/blob/a21a3bbe/core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---------------------------------------------------------------------- diff --git a/core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala b/core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala index 8ce8fb1..371fb86 100644 --- a/core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala +++ b/core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala @@ -389,11 +389,6 @@ private[spark] class TaskSchedulerImpl( // (taskId, stageId, stageAttemptId, accumUpdates) val accumUpdatesWithTaskIds: Array[(Long, Int, Int, Seq[AccumulableInfo])] = synchronized { accumUpdates.flatMap { case (id, updates) => - // We should call `acc.value` here as we are at driver side now. However, the RPC framework - // optimizes local message delivery so that messages do not need to de serialized and - // deserialized. This brings trouble to the accumulator framework, which depends on - // serialization to set the `atDriverSide` flag. Here we call `acc.localValue` instead to - // be more robust about this issue. val accInfos = updates.map(acc => acc.toInfo(Some(acc.value), None)) taskIdToTaskSetManager.get(id).map { taskSetMgr => (id, taskSetMgr.stageId, taskSetMgr.taskSet.stageAttemptId, accInfos) --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
