Repository: spark Updated Branches: refs/heads/master cfcca732b -> 0f02a5c6e
[MINOR][MLLIB] Remove TODO comment DecisionTreeModel.scala ## What changes were proposed in this pull request? This PR fixes the following line and the related code. Historically, this code was added in [SPARK-5597](https://issues.apache.org/jira/browse/SPARK-5597). After [SPARK-5597](https://issues.apache.org/jira/browse/SPARK-5597) was committed, [SPARK-3365](https://issues.apache.org/jira/browse/SPARK-3365) is fixed now. Now, we had better remove the comment without changing persistent code. ```scala - categories: Seq[Double]) { // TODO: Change to List once SPARK-3365 is fixed + categories: Seq[Double]) { ``` ## How was this patch tested? Pass the Jenkins tests. Author: Dongjoon Hyun <[email protected]> Closes #11966 from dongjoon-hyun/change_categories_type. Project: http://git-wip-us.apache.org/repos/asf/spark/repo Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/0f02a5c6 Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/0f02a5c6 Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/0f02a5c6 Branch: refs/heads/master Commit: 0f02a5c6e63a95f910e6aba572729ca8085ac3ab Parents: cfcca73 Author: Dongjoon Hyun <[email protected]> Authored: Sun Mar 27 20:07:31 2016 +0100 Committer: Sean Owen <[email protected]> Committed: Sun Mar 27 20:07:31 2016 +0100 ---------------------------------------------------------------------- .../org/apache/spark/mllib/tree/model/DecisionTreeModel.scala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/spark/blob/0f02a5c6/mllib/src/main/scala/org/apache/spark/mllib/tree/model/DecisionTreeModel.scala ---------------------------------------------------------------------- diff --git a/mllib/src/main/scala/org/apache/spark/mllib/tree/model/DecisionTreeModel.scala b/mllib/src/main/scala/org/apache/spark/mllib/tree/model/DecisionTreeModel.scala index ea68ff6..a87f8a6 100644 --- a/mllib/src/main/scala/org/apache/spark/mllib/tree/model/DecisionTreeModel.scala +++ b/mllib/src/main/scala/org/apache/spark/mllib/tree/model/DecisionTreeModel.scala @@ -156,7 +156,7 @@ object DecisionTreeModel extends Loader[DecisionTreeModel] with Logging { feature: Int, threshold: Double, featureType: Int, - categories: Seq[Double]) { // TODO: Change to List once SPARK-3365 is fixed + categories: Seq[Double]) { def toSplit: Split = { new Split(feature, threshold, FeatureType(featureType), categories.toList) } --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
