Repository: spark
Updated Branches:
  refs/heads/master 902667fd2 -> bcc7373f6


[SPARK-12821][BUILD] Style checker should run when some configuration files for 
style are modified but any source files are not.

When running the `run-tests` script, style checkers run only when any source 
files are modified but they should run when configuration files related to 
style are modified.

Author: Kousuke Saruta <[email protected]>

Closes #10754 from sarutak/SPARK-12821.


Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/bcc7373f
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/bcc7373f
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/bcc7373f

Branch: refs/heads/master
Commit: bcc7373f673d1a51b48fb95432ba5c4644dd5d23
Parents: 902667f
Author: Kousuke Saruta <[email protected]>
Authored: Thu Jan 14 10:43:39 2016 -0800
Committer: Josh Rosen <[email protected]>
Committed: Thu Jan 14 10:43:39 2016 -0800

----------------------------------------------------------------------
 dev/run-tests.py | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/spark/blob/bcc7373f/dev/run-tests.py
----------------------------------------------------------------------
diff --git a/dev/run-tests.py b/dev/run-tests.py
index 8726889..795db0d 100755
--- a/dev/run-tests.py
+++ b/dev/run-tests.py
@@ -529,9 +529,14 @@ def main():
     run_apache_rat_checks()
 
     # style checks
-    if not changed_files or any(f.endswith(".scala") for f in changed_files):
+    if not changed_files or any(f.endswith(".scala")
+                                or f.endswith("scalastyle-config.xml")
+                                for f in changed_files):
         run_scala_style_checks()
-    if not changed_files or any(f.endswith(".java") for f in changed_files):
+    if not changed_files or any(f.endswith(".java")
+                                or f.endswith("checkstyle.xml")
+                                or f.endswith("checkstyle-suppressions.xml")
+                                for f in changed_files):
         # run_java_style_checks()
         pass
     if not changed_files or any(f.endswith(".py") for f in changed_files):


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to