Repository: spark
Updated Branches:
  refs/heads/master af2effdd7 -> d9a8bae77


[DOCS] Refactored Dataframe join comment to use correct parameter ordering

The API signatire for join requires the JoinType to be the third parameter. The 
code examples provided for join show JoinType being provided as the 2nd parater 
resuling in errors (i.e. "df1.join(df2, "outer", $"df1Key" === $"df2Key") ). 
The correct sample code is df1.join(df2, $"df1Key" === $"df2Key", "outer")

Author: Paul Power <[email protected]>

Closes #4847 from peerside/master and squashes the following commits:

ebc1efa [Paul Power] Merge pull request #1 from peerside/peerside-patch-1
e353340 [Paul Power] Updated comments use correct sample code for Dataframe 
joins


Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/d9a8bae7
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/d9a8bae7
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/d9a8bae7

Branch: refs/heads/master
Commit: d9a8bae77826a0cc77df29d85883e914d0f0b4f3
Parents: af2effd
Author: Paul Power <[email protected]>
Authored: Mon Mar 2 13:08:47 2015 -0800
Committer: Michael Armbrust <[email protected]>
Committed: Mon Mar 2 13:09:35 2015 -0800

----------------------------------------------------------------------
 sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/spark/blob/d9a8bae7/sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala
----------------------------------------------------------------------
diff --git a/sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala 
b/sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala
index 060ab5e..f3aac08 100644
--- a/sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala
+++ b/sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala
@@ -337,11 +337,11 @@ class DataFrame protected[sql](
    * {{{
    *   // Scala:
    *   import org.apache.spark.sql.functions._
-   *   df1.join(df2, "outer", $"df1Key" === $"df2Key")
+   *   df1.join(df2, $"df1Key" === $"df2Key", "outer")
    *
    *   // Java:
    *   import static org.apache.spark.sql.functions.*;
-   *   df1.join(df2, "outer", col("df1Key") === col("df2Key"));
+   *   df1.join(df2, col("df1Key").equalTo(col("df2Key")), "outer");
    * }}}
    *
    * @param right Right side of the join.


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to