Repository: spark Updated Branches: refs/heads/master 0c5c6a63d -> e3643485d
[SPARK-2730][SQL] When retrieving a value from a Map, GetItem evaluates key twice JIRA: https://issues.apache.org/jira/browse/SPARK-2730 Author: Yin Huai <[email protected]> Closes #1637 from yhuai/SPARK-2730 and squashes the following commits: 1a9f24e [Yin Huai] Remove unnecessary key evaluation. Project: http://git-wip-us.apache.org/repos/asf/spark/repo Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/e3643485 Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/e3643485 Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/e3643485 Branch: refs/heads/master Commit: e3643485de8fdaf5c52b266fead1b13214f29d5e Parents: 0c5c6a6 Author: Yin Huai <[email protected]> Authored: Tue Jul 29 12:23:34 2014 -0700 Committer: Michael Armbrust <[email protected]> Committed: Tue Jul 29 12:23:34 2014 -0700 ---------------------------------------------------------------------- .../org/apache/spark/sql/catalyst/expressions/complexTypes.scala | 1 - 1 file changed, 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/spark/blob/e3643485/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypes.scala ---------------------------------------------------------------------- diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypes.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypes.scala index 5d3bb25..0acb290 100644 --- a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypes.scala +++ b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypes.scala @@ -61,7 +61,6 @@ case class GetItem(child: Expression, ordinal: Expression) extends Expression { } } else { val baseValue = value.asInstanceOf[Map[Any, _]] - val key = ordinal.eval(input) baseValue.get(key).orNull } }
