Repository: spark
Updated Branches:
  refs/heads/master 9fe28c35d -> 409d24e2b


SPARK-2229: FileAppender throw an llegalArgumentException in jdk6

Author: witgo <[email protected]>

Closes #1174 from witgo/SPARK-2229 and squashes the following commits:

f85f321 [witgo] FileAppender throw anIllegalArgumentException in JDK6
e1a8da8 [witgo] SizeBasedRollingPolicy throw an 
java.lang.IllegalArgumentException in JDK6


Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/409d24e2
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/409d24e2
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/409d24e2

Branch: refs/heads/master
Commit: 409d24e2b2e52df8fd2c5aca69def29b9a097a79
Parents: 9fe28c3
Author: witgo <[email protected]>
Authored: Sun Jun 22 18:25:16 2014 -0700
Committer: Reynold Xin <[email protected]>
Committed: Sun Jun 22 18:25:16 2014 -0700

----------------------------------------------------------------------
 .../scala/org/apache/spark/util/logging/FileAppender.scala   | 8 ++++----
 .../scala/org/apache/spark/util/logging/RollingPolicy.scala  | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/spark/blob/409d24e2/core/src/main/scala/org/apache/spark/util/logging/FileAppender.scala
----------------------------------------------------------------------
diff --git 
a/core/src/main/scala/org/apache/spark/util/logging/FileAppender.scala 
b/core/src/main/scala/org/apache/spark/util/logging/FileAppender.scala
index 8e9c303..1d54670 100644
--- a/core/src/main/scala/org/apache/spark/util/logging/FileAppender.scala
+++ b/core/src/main/scala/org/apache/spark/util/logging/FileAppender.scala
@@ -125,16 +125,16 @@ private[spark] object FileAppender extends Logging {
       val validatedParams: Option[(Long, String)] = rollingInterval match {
         case "daily" =>
           logInfo(s"Rolling executor logs enabled for $file with daily 
rolling")
-          Some(24 * 60 * 60 * 1000L, "--YYYY-MM-dd")
+          Some(24 * 60 * 60 * 1000L, "--yyyy-MM-dd")
         case "hourly" =>
           logInfo(s"Rolling executor logs enabled for $file with hourly 
rolling")
-          Some(60 * 60 * 1000L, "--YYYY-MM-dd--HH")
+          Some(60 * 60 * 1000L, "--yyyy-MM-dd--HH")
         case "minutely" =>
           logInfo(s"Rolling executor logs enabled for $file with rolling every 
minute")
-          Some(60 * 1000L, "--YYYY-MM-dd--HH-mm")
+          Some(60 * 1000L, "--yyyy-MM-dd--HH-mm")
         case IntParam(seconds) =>
           logInfo(s"Rolling executor logs enabled for $file with rolling 
$seconds seconds")
-          Some(seconds * 1000L, "--YYYY-MM-dd--HH-mm-ss")
+          Some(seconds * 1000L, "--yyyy-MM-dd--HH-mm-ss")
         case _ =>
           logWarning(s"Illegal interval for rolling executor logs 
[$rollingInterval], " +
               s"rolling logs not enabled")

http://git-wip-us.apache.org/repos/asf/spark/blob/409d24e2/core/src/main/scala/org/apache/spark/util/logging/RollingPolicy.scala
----------------------------------------------------------------------
diff --git 
a/core/src/main/scala/org/apache/spark/util/logging/RollingPolicy.scala 
b/core/src/main/scala/org/apache/spark/util/logging/RollingPolicy.scala
index 84e5c3c..d7b7219 100644
--- a/core/src/main/scala/org/apache/spark/util/logging/RollingPolicy.scala
+++ b/core/src/main/scala/org/apache/spark/util/logging/RollingPolicy.scala
@@ -109,7 +109,7 @@ private[spark] class SizeBasedRollingPolicy(
   }
 
   @volatile private var bytesWrittenSinceRollover = 0L
-  val formatter = new SimpleDateFormat("--YYYY-MM-dd--HH-mm-ss--SSSS")
+  val formatter = new SimpleDateFormat("--yyyy-MM-dd--HH-mm-ss--SSSS")
 
   /** Should rollover if the next set of bytes is going to exceed the size 
limit */
   def shouldRollover(bytesToBeWritten: Long): Boolean = {

Reply via email to