This is an automated email from the ASF dual-hosted git repository. rombert pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/sling-whiteboard.git
commit da74191abd6c68891e49c285c9369fb70d4ce3bf Author: Robert Munteanu <[email protected]> AuthorDate: Wed Apr 22 15:02:54 2026 +0200 feat(skill_evals): more precise prompts --- skill-evals/src/skill_evals/jcr_js_nodetypes/dataset.jsonl | 2 +- skill-evals/src/skill_evals/jcr_js_nodetypes/task.py | 14 ++++++++------ 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/skill-evals/src/skill_evals/jcr_js_nodetypes/dataset.jsonl b/skill-evals/src/skill_evals/jcr_js_nodetypes/dataset.jsonl index 322c5fad..33a1c824 100644 --- a/skill-evals/src/skill_evals/jcr_js_nodetypes/dataset.jsonl +++ b/skill-evals/src/skill_evals/jcr_js_nodetypes/dataset.jsonl @@ -1 +1 @@ -{"id":"upgrade-parent-pom","input":"update to the next parent pom version","git_revision":"52cea70b190c8389495a4fa494161eac13416891","expected_parent_version":"23"} +{"id":"upgrade-parent-pom","input":"Update to parent pom version {expected_parent_version}","git_revision":"52cea70b190c8389495a4fa494161eac13416891","expected_parent_version":"23"} diff --git a/skill-evals/src/skill_evals/jcr_js_nodetypes/task.py b/skill-evals/src/skill_evals/jcr_js_nodetypes/task.py index c3d22b63..4cf79f0d 100644 --- a/skill-evals/src/skill_evals/jcr_js_nodetypes/task.py +++ b/skill-evals/src/skill_evals/jcr_js_nodetypes/task.py @@ -23,14 +23,16 @@ def _skill_paths() -> list[Path]: def _record_to_sample(record: dict, *, skill_enabled: bool) -> Sample: + metadata = { + "skill_enabled": skill_enabled, + "git_revision": record["git_revision"], + "expected_parent_version": record["expected_parent_version"], + } + return Sample( id=record.get("id"), - input=record["input"], - metadata={ - "skill_enabled": skill_enabled, - "git_revision": record["git_revision"], - "expected_parent_version": record["expected_parent_version"], - }, + input=record["input"].format(**metadata), + metadata=metadata, files={"/workspace/eval-assets/setup.sh": str(_task_dir() / "setup.sh")}, setup=f"sh /workspace/eval-assets/setup.sh {record['git_revision']}", )
