[sis] 04/05: Relax a check from `assertSame(…) to `assertEquals(…)` for test that may depend on execution order. With Maven, we used some custom annotation for controlling JUnit execution order. After JPMS migration, we will have (at least temporarily) less control on that.

[desruisseaux]

This is an automated email from the ASF dual-hosted git repository.

desruisseaux pushed a commit to branch geoapi-4.0
in repository https://gitbox.apache.org/repos/asf/sis.git

commit 25eb197481decb91c8a4dadf770c4bcf0cb7c693
Author: Martin Desruisseaux <martin.desruisse...@geomatys.com>
AuthorDate: Thu Jul 6 17:24:50 2023 +0200

    Relax a check from `assertSame(…) to `assertEquals(…)` for test that may 
depend on execution order.
    With Maven, we used some custom annotation for controlling JUnit execution 
order.
    After JPMS migration, we will have (at least temporarily) less control on 
that.
---
 .../sis/referencing/factory/sql/EPSGFactoryTest.java       | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git 
a/core/sis-referencing/src/test/java/org/apache/sis/referencing/factory/sql/EPSGFactoryTest.java
 
b/core/sis-referencing/src/test/java/org/apache/sis/referencing/factory/sql/EPSGFactoryTest.java
index 240198e084..d4e3efe06d 100644
--- 
a/core/sis-referencing/src/test/java/org/apache/sis/referencing/factory/sql/EPSGFactoryTest.java
+++ 
b/core/sis-referencing/src/test/java/org/apache/sis/referencing/factory/sql/EPSGFactoryTest.java
@@ -82,7 +82,7 @@ import static 
org.apache.sis.referencing.Assertions.assertAliasTipEquals;
  *
  * @author  Martin Desruisseaux (IRD, Geomatys)
  * @author  Vadim Semenov
- * @version 1.2
+ * @version 1.4
  * @since   0.7
  */
 @DependsOn({
@@ -303,10 +303,10 @@ public final class EPSGFactoryTest extends TestCase {
         assertEpsgNameAndIdentifierEqual("UTM zone 10N", 16010, 
variant.getConversionFromBase());
         
verifyTransverseMercatorParmeters(crs.getConversionFromBase().getParameterValues(),
 -123);
 
-        assertSame("Operation method", crs.getConversionFromBase().getMethod(),
-                                   
variant.getConversionFromBase().getMethod());
-        assertSame("Coordinate system", crs.getCoordinateSystem(),
-                                    variant.getCoordinateSystem());
+        assertEquals("Operation method", 
crs.getConversionFromBase().getMethod(),
+                                     
variant.getConversionFromBase().getMethod());
+        assertEquals("Coordinate system", crs.getCoordinateSystem(),
+                                      variant.getCoordinateSystem());
 
         assertNotDeepEquals(crs.getConversionFromBase(), 
variant.getConversionFromBase());
         assertNotDeepEquals(crs, variant);
@@ -807,8 +807,8 @@ public final class EPSGFactoryTest extends TestCase {
         assertEpsgNameAndIdentifierEqual("Transverse Mercator", 9807, 
copMethod);
         assertEpsgNameAndIdentifierEqual("Transverse Mercator", 9807, 
crsMethod);
         try {
-            assertSame("Conversion method", copMethod, crsMethod);
-            assertSame("Conversion method", copMethod, 
factory.createOperationMethod("9807"));
+            assertEquals("Conversion method", copMethod, crsMethod);
+            assertEquals("Conversion method", copMethod, 
factory.createOperationMethod("9807"));
         } catch (AssertionError error) {
             out.println("The following contains more information about a JUnit 
test failure.");
             out.println("See the JUnit report for the stack trace. Below is a 
cache dump.");