This is an automated email from the ASF dual-hosted git repository.
desruisseaux pushed a commit to branch geoapi-4.0
in repository https://gitbox.apache.org/repos/asf/sis.git
commit d3560bffc59a022f85c222e020f968dee3eecd90
Author: Martin Desruisseaux <martin.desruisse...@geomatys.com>
AuthorDate: Thu Nov 25 11:03:16 2021 +0100
Minor fixes for javadoc, formatting and state of immutable object.
---
.../src/main/java/org/apache/sis/gui/map/MapCanvasAWT.java | 2 +-
.../main/java/org/apache/sis/coverage/grid/GridGeometry.java | 2 +-
.../org/apache/sis/test/storage/CoverageReadConsistency.java | 11 ++++++-----
3 files changed, 8 insertions(+), 7 deletions(-)
diff --git
a/application/sis-javafx/src/main/java/org/apache/sis/gui/map/MapCanvasAWT.java
b/application/sis-javafx/src/main/java/org/apache/sis/gui/map/MapCanvasAWT.java
index 0bb9da6..820393e 100644
---
a/application/sis-javafx/src/main/java/org/apache/sis/gui/map/MapCanvasAWT.java
+++
b/application/sis-javafx/src/main/java/org/apache/sis/gui/map/MapCanvasAWT.java
@@ -342,7 +342,7 @@ public abstract class MapCanvasAWT extends MapCanvas {
* <h4>Preconditions</h4>
* It is important that no other worker is in progress at the time this
method is invoked
* ({@code assert renderingInProgress == null}), otherwise conflicts may
happen when workers
- * will update the {@code MapCanvasAWT} fields after they completed their
task.</p>
+ * will update the {@code MapCanvasAWT} fields after they completed their
task.
*
* @see #requestRepaint()
*/
diff --git
a/core/sis-feature/src/main/java/org/apache/sis/coverage/grid/GridGeometry.java
b/core/sis-feature/src/main/java/org/apache/sis/coverage/grid/GridGeometry.java
index 8c5e7a1..720fd8d 100644
---
a/core/sis-feature/src/main/java/org/apache/sis/coverage/grid/GridGeometry.java
+++
b/core/sis-feature/src/main/java/org/apache/sis/coverage/grid/GridGeometry.java
@@ -906,7 +906,7 @@ public class GridGeometry implements LenientComparable,
Serializable {
if (getCoordinateReferenceSystem(envelope) != null &&
!envelope.isAllNaN()) {
try {
final DefaultGeographicBoundingBox db =
ReferencingServices.getInstance().setBounds(envelope, null, null);
-
db.transitionTo(DefaultGeographicBoundingBox.State.EDITABLE);
+ db.transitionTo(DefaultGeographicBoundingBox.State.FINAL);
bbox = db;
} catch (TransformException e) {
bbox =
NilReason.INAPPLICABLE.createNilObject(GeographicBoundingBox.class);
diff --git
a/storage/sis-storage/src/test/java/org/apache/sis/test/storage/CoverageReadConsistency.java
b/storage/sis-storage/src/test/java/org/apache/sis/test/storage/CoverageReadConsistency.java
index e7ad7c1..f81231d 100644
---
a/storage/sis-storage/src/test/java/org/apache/sis/test/storage/CoverageReadConsistency.java
+++
b/storage/sis-storage/src/test/java/org/apache/sis/test/storage/CoverageReadConsistency.java
@@ -48,7 +48,8 @@ import static org.junit.Assert.*;
/**
* Base class for testing the consistency of grid coverage read operations.
- * The test reads the grid coverage in full, then reads random sub-regions.
+ * The test reads the whole grid coverage at full resolution,
+ * then reads random sub-regions at random resolutions.
* The sub-regions pixels are compared with the original image.
*
* <h2>Assumptions</h2>
@@ -205,7 +206,7 @@ public strictfp class CoverageReadConsistency extends
TestCase {
@Test
@DependsOnMethod({"testSubsamplingAtOrigin", "testSubRegionsAnywhere"})
public void testSubsamplingAnywhere() throws DataStoreException {
- allowOffsets = true;
+ allowOffsets = true;
allowSubsampling = true;
readAndCompareRandomRegions("Subsampling");
}
@@ -244,10 +245,10 @@ public strictfp class CoverageReadConsistency extends
TestCase {
@Test
@DependsOnMethod({"testBandSubsetAnywhere", "testSubsamplingAnywhere"})
public void testAllAnywhere() throws DataStoreException {
- allowOffsets = true;
- allowBandSubset = true;
+ allowOffsets = true;
+ allowBandSubset = true;
allowSubsampling = true;
- readAndCompareRandomRegions("All (ms)");
+ readAndCompareRandomRegions("All");
}
/**
