This is an automated email from the ASF dual-hosted git repository. amanin pushed a commit to branch fix/projection_name_clash in repository https://gitbox.apache.org/repos/asf/sis.git
commit 7b8a6a607ea9d03b6acecee45d3ccd61433d03ad Author: Alexis Manin <alexis.ma...@geomatys.com> AuthorDate: Wed Nov 24 12:10:14 2021 +0100 chore(Storage): add a test case for column definition ambiguity. --- .../test/java/org/apache/sis/storage/FeatureQueryTest.java | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/storage/sis-storage/src/test/java/org/apache/sis/storage/FeatureQueryTest.java b/storage/sis-storage/src/test/java/org/apache/sis/storage/FeatureQueryTest.java index 6918ac9..f675e4f 100644 --- a/storage/sis-storage/src/test/java/org/apache/sis/storage/FeatureQueryTest.java +++ b/storage/sis-storage/src/test/java/org/apache/sis/storage/FeatureQueryTest.java @@ -37,6 +37,7 @@ import org.opengis.filter.Filter; import org.opengis.filter.FilterFactory; import org.opengis.filter.MatchAction; import org.opengis.filter.SortOrder; +import org.opengis.filter.SortProperty; /** @@ -209,4 +210,15 @@ public final strictfp class FeatureQueryTest extends TestCase { final PropertyType p = TestUtilities.getSingleton(result.getType().getProperties(true)); assertEquals("value2", p.getName().toString()); } + + @Test + public void testColumnNameClash() throws DataStoreException { + final FilterFactory<Feature,?,?> ff = DefaultFilterFactory.forFeatures(); + query.setProjection( + ff.add(ff.property("value1", Number.class), ff.literal(1)), + ff.add(ff.property("value2", Number.class), ff.literal(1))); + final FeatureSet subset = featureSet.subset(query); // NOTE: I would expect an error here + final FeatureType type = subset.getType(); + assertEquals(2, type.getProperties(true).size()); + } }