EnableAsync commented on code in PR #9483:
URL: https://github.com/apache/rocketmq/pull/9483#discussion_r2154477085
##########
proxy/src/main/java/org/apache/rocketmq/proxy/grpc/ProxyAndTlsProtocolNegotiator.java:
##########
@@ -73,7 +80,13 @@ public class ProxyAndTlsProtocolNegotiator implements
InternalProtocolNegotiator
private static SslContext sslContext;
public ProxyAndTlsProtocolNegotiator() {
- sslContext = loadSslContext();
+ try {
+ loadSslContext();
+ log.info("SSLContext created for proxy server");
+ } catch (IOException | CertificateException e) {
Review Comment:
Here we want to crash directly if an exception is thrown during SSLContext
initialization
##########
proxy/src/main/java/org/apache/rocketmq/proxy/grpc/ProxyAndTlsProtocolNegotiator.java:
##########
@@ -73,7 +80,13 @@ public class ProxyAndTlsProtocolNegotiator implements
InternalProtocolNegotiator
private static SslContext sslContext;
public ProxyAndTlsProtocolNegotiator() {
- sslContext = loadSslContext();
+ try {
+ loadSslContext();
+ log.info("SSLContext created for proxy server");
+ } catch (IOException | CertificateException e) {
Review Comment:
Here I want to crash directly if an exception is thrown during SSLContext
initialization
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
