lizhimins commented on code in PR #9256:
URL: https://github.com/apache/rocketmq/pull/9256#discussion_r2113349006
##########
store/src/main/java/org/apache/rocketmq/store/metrics/RocksDBStoreMetricsManager.java:
##########
@@ -78,50 +78,62 @@ public static List<Pair<InstrumentSelector, ViewBuilder>>
getMetricsView() {
}
public static void init(Meter meter, Supplier<AttributesBuilder>
attributesBuilderSupplier,
- RocksDBMessageStore messageStore) {
+ ConsumeQueueStoreInterface consumeQueueStore) {
+
+ final RocksDBConsumeQueueStore rocksDBMessageStore;
+ if (consumeQueueStore instanceof RocksDBConsumeQueueStore) {
+ rocksDBMessageStore = (RocksDBConsumeQueueStore) consumeQueueStore;
+ } else if (consumeQueueStore instanceof CombineConsumeQueueStore) {
+ rocksDBMessageStore = ((CombineConsumeQueueStore)
consumeQueueStore).getRocksDBConsumeQueueStore();
Review Comment:
这段的类型转换有点怪啊
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
